From: Igor Mammedov <imammedo@redhat.com>
To: qemu-devel@nongnu.org
Cc: ehabkost@redhat.com, mst@redhat.com
Subject: Re: [Qemu-devel] [PATCH for-3.0] pc: acpi: fix memhp regression by reducing stub SRAT entry size
Date: Mon, 30 Jul 2018 13:04:25 +0200 [thread overview]
Message-ID: <20180730130425.61884cc3@redhat.com> (raw)
In-Reply-To: <1532703031-166467-1-git-send-email-imammedo@redhat.com>
On Fri, 27 Jul 2018 16:50:31 +0200
Igor Mammedov <imammedo@redhat.com> wrote:
> Commit 848a1cc1e (hw/acpi-build: build SRAT memory affinity structures for DIMM devices)
> broke the first dimm hotplug in following cases:
>
> 1: there is no coldplugged dimm in the last numa node
> but there is a coldplugged dimm in another node
>
> -m 4096,slots=4,maxmem=32G \
> -object memory-backend-ram,size=2G,id=m0 \
> -device pc-dimm,memdev=m0,node=1 \
> -object memory-backend-ram,id=m1,size=2G \
> -device pc-dimm,memdev=m1,node=0 \
> -numa node,nodeid=0 \
> -numa node,nodeid=1
>
> 2: if order of dimms on CLI is:
> 1st plugged dimm in node1
> 2nd plugged dimm in node0
>
> -m 4096,slots=4,maxmem=32G \
> -object memory-backend-ram,id=m1,size=2G \
> -device pc-dimm,memdev=m1,node=0 \
> -numa node,nodeid=0 \
> -numa node,nodeid=1
>
self-NACK on this one,
I've mixed up examples in commit message, it should have been other way around.
I've just posted v2 with fixed commit message
[...]
prev parent reply other threads:[~2018-07-30 11:04 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-27 14:50 [Qemu-devel] [PATCH for-3.0] pc: acpi: fix memhp regression by reducing stub SRAT entry size Igor Mammedov
2018-07-27 21:52 ` Eduardo Habkost
2018-07-28 21:09 ` Michael S. Tsirkin
2018-07-30 7:49 ` Igor Mammedov
2018-07-30 11:04 ` Igor Mammedov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180730130425.61884cc3@redhat.com \
--to=imammedo@redhat.com \
--cc=ehabkost@redhat.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).