From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
To: Juan Quintela <quintela@redhat.com>
Cc: Li Qiang <liq3ea@gmail.com>,
pbonzini@redhat.com, crosthwaite.peter@gmail.com,
rth@twiddle.net, eblake@redhat.com, armbru@redhat.com,
liqiang02@corp.netease.com, hzliuyingdong@corp.netease.com,
qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 2/3] migration: Add qmp command for migrate_set_max_cpu_throttle
Date: Tue, 31 Jul 2018 16:38:05 +0100 [thread overview]
Message-ID: <20180731153805.GL2476@work-vm> (raw)
In-Reply-To: <87o9enqx4s.fsf@trasno.org>
* Juan Quintela (quintela@redhat.com) wrote:
> "Dr. David Alan Gilbert" <dgilbert@redhat.com> wrote:
> > * Li Qiang (liq3ea@gmail.com) wrote:
> >> The default max cpu throttle is 99, this is too big that may
> >> influence the guest loads. Add a qmp to config it can make it
> >> more flexible.
> >>
> >> Signed-off-by: Li Qiang <liq3ea@gmail.com>
> >
> > This should be done as a migration parameter rather than a new command.
> > For example, follow the cpu-throttle-increment parameter; and this
> > should work just like it.
>
> I was about to comment this one.
>
> migrate_set_downtime, migrate_set_speed, migrate-set-cache-size,
> query-migrate-cache-size are marked as deprecated. Any way that we
> could have make more clear that one should use
> migrate_set/get_parameter/capability?
A big hairy comment?
Dave
> Thanks, Juan.
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK
next prev parent reply other threads:[~2018-07-31 15:38 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-31 8:35 [Qemu-devel] [PATCH 0/3] Add a new migrate_set_max_cpu_throttle qmp command Li Qiang
2018-07-31 8:35 ` [Qemu-devel] [PATCH 1/3] migrate: replace the cpu throttle percentage max with a variable Li Qiang
2018-07-31 8:35 ` [Qemu-devel] [PATCH 2/3] migration: Add qmp command for migrate_set_max_cpu_throttle Li Qiang
2018-07-31 11:29 ` Dr. David Alan Gilbert
2018-07-31 12:22 ` Eric Blake
2018-07-31 14:48 ` Juan Quintela
2018-07-31 15:38 ` Dr. David Alan Gilbert [this message]
2018-07-31 15:50 ` Daniel P. Berrangé
2018-08-01 1:14 ` Li Qiang
2018-08-01 8:01 ` Juan Quintela
2018-07-31 8:35 ` [Qemu-devel] [PATCH 3/3] hmp: add hmp " Li Qiang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180731153805.GL2476@work-vm \
--to=dgilbert@redhat.com \
--cc=armbru@redhat.com \
--cc=crosthwaite.peter@gmail.com \
--cc=eblake@redhat.com \
--cc=hzliuyingdong@corp.netease.com \
--cc=liq3ea@gmail.com \
--cc=liqiang02@corp.netease.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).