From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54637) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fkmRV-0006be-0z for qemu-devel@nongnu.org; Wed, 01 Aug 2018 04:25:14 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fkmRR-0003g7-Mk for qemu-devel@nongnu.org; Wed, 01 Aug 2018 04:25:13 -0400 Received: from mga03.intel.com ([134.134.136.65]:8572) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1fkmRR-0003fe-Bz for qemu-devel@nongnu.org; Wed, 01 Aug 2018 04:25:09 -0400 Date: Wed, 1 Aug 2018 16:22:44 +0800 From: Tiwei Bie Message-ID: <20180801082244.GA11408@debian.sh.intel.com> References: <20180720083644.1431-1-tiwei.bie@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20180720083644.1431-1-tiwei.bie@intel.com> Subject: Re: [Qemu-devel] [PATCH] vhost: check region type before casting List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: mst@redhat.com, jasowang@redhat.com Cc: Peter Maydell , qemu-devel@nongnu.org Ping.. It seems that the final release for QEMU 3.0 will be out soon [1]. But this fix hasn't been merged yet. [1] https://lists.nongnu.org/archive/html/qemu-devel/2018-07/msg06004.html Thanks, Tiwei On Fri, Jul 20, 2018 at 04:36:44PM +0800, Tiwei Bie wrote: > Check region type first before casting the memory region > to IOMMUMemoryRegion. Otherwise QEMU will abort with below > error message when casting non-IOMMU memory region: > > vhost_iommu_region_add: Object 0x561f28bce4f0 is not an > instance of type qemu:iommu-memory-region > > Fixes: cb1efcf462a2 ("iommu: Add IOMMU index argument to notifier APIs") > Cc: Peter Maydell > > Signed-off-by: Tiwei Bie > --- > hw/virtio/vhost.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/hw/virtio/vhost.c b/hw/virtio/vhost.c > index b129cb9ddd..d4cb5894a8 100644 > --- a/hw/virtio/vhost.c > +++ b/hw/virtio/vhost.c > @@ -663,12 +663,14 @@ static void vhost_iommu_region_add(MemoryListener *listener, > struct vhost_iommu *iommu; > Int128 end; > int iommu_idx; > - IOMMUMemoryRegion *iommu_mr = IOMMU_MEMORY_REGION(section->mr); > + IOMMUMemoryRegion *iommu_mr; > > if (!memory_region_is_iommu(section->mr)) { > return; > } > > + iommu_mr = IOMMU_MEMORY_REGION(section->mr); > + > iommu = g_malloc0(sizeof(*iommu)); > end = int128_add(int128_make64(section->offset_within_region), > section->size); > -- > 2.18.0 > >