From: Cornelia Huck <cohuck@redhat.com>
To: Fam Zheng <famz@redhat.com>
Cc: qemu-s390x@nongnu.org, Xiao Feng Ren <renxiaof@linux.ibm.com>,
Thomas Huth <thuth@redhat.com>,
David Hildenbrand <david@redhat.com>,
libvir-list@redhat.com, Alexander Graf <agraf@suse.de>,
qemu-devel@nongnu.org, Halil Pasic <pasic@linux.ibm.com>,
Christian Borntraeger <borntraeger@de.ibm.com>,
Richard Henderson <rth@twiddle.net>
Subject: Re: [Qemu-devel] [PATCH for-3.1] s390x: remove 's390-squash-mcss' option
Date: Wed, 1 Aug 2018 15:11:23 +0200 [thread overview]
Message-ID: <20180801151123.5a52e0e6.cohuck@redhat.com> (raw)
In-Reply-To: <20180801145451.2e640621.cohuck@redhat.com>
On Wed, 1 Aug 2018 14:54:51 +0200
Cornelia Huck <cohuck@redhat.com> wrote:
> On Wed, 1 Aug 2018 18:21:27 +0800
> Fam Zheng <famz@redhat.com> wrote:
>
> > On Tue, 07/24 11:24, Cornelia Huck wrote:
> > > diff --git a/hw/s390x/css-bridge.c b/hw/s390x/css-bridge.c
> > > index a02d708239..1bd6c8b458 100644
> > > --- a/hw/s390x/css-bridge.c
> > > +++ b/hw/s390x/css-bridge.c
> > > @@ -106,7 +106,6 @@ VirtualCssBus *virtual_css_bus_init(void)
> > > /* Create bus on bridge device */
> > > bus = qbus_create(TYPE_VIRTUAL_CSS_BUS, dev, "virtual-css");
> > > cbus = VIRTUAL_CSS_BUS(bus);
> >
> > Not used now?
> >
> > Fam
>
> Indeed, we can ditch the cbus variable.
...or not :) We still need it for the return value, which is processed
in ccw_init(). We could change the return code of the function to
BusState, but I'm not sure it is worth the hassle.
next prev parent reply other threads:[~2018-08-01 13:11 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-24 9:24 [Qemu-devel] [PATCH for-3.1] s390x: remove 's390-squash-mcss' option Cornelia Huck
2018-07-24 11:03 ` Christian Borntraeger
2018-07-24 11:15 ` [Qemu-devel] [libvirt] " Peter Krempa
2018-07-24 11:23 ` Cornelia Huck
2018-07-24 11:48 ` [Qemu-devel] " Thomas Huth
2018-07-30 13:25 ` Halil Pasic
2018-07-30 13:43 ` Cornelia Huck
2018-08-01 10:21 ` Fam Zheng
2018-08-01 12:54 ` Cornelia Huck
2018-08-01 13:11 ` Cornelia Huck [this message]
2018-08-01 13:18 ` Cornelia Huck
2018-08-02 1:34 ` Fam Zheng
2018-08-02 7:15 ` Cornelia Huck
2018-08-02 7:33 ` Cornelia Huck
2018-08-02 7:44 ` Cornelia Huck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180801151123.5a52e0e6.cohuck@redhat.com \
--to=cohuck@redhat.com \
--cc=agraf@suse.de \
--cc=borntraeger@de.ibm.com \
--cc=david@redhat.com \
--cc=famz@redhat.com \
--cc=libvir-list@redhat.com \
--cc=pasic@linux.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-s390x@nongnu.org \
--cc=renxiaof@linux.ibm.com \
--cc=rth@twiddle.net \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).