qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Cornelia Huck <cohuck@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: qemu-devel@nongnu.org, qemu-s390x@nongnu.org,
	e.emanuelegiuseppe@gmail.com
Subject: Re: [Qemu-devel] [PATCH] tests: virtio: separate ccw tests from libqos
Date: Wed, 1 Aug 2018 15:34:19 +0200	[thread overview]
Message-ID: <20180801153419.08e12a63.cohuck@redhat.com> (raw)
In-Reply-To: <20180801132733.15628-1-pbonzini@redhat.com>

On Wed,  1 Aug 2018 15:27:33 +0200
Paolo Bonzini <pbonzini@redhat.com> wrote:

> Because qtest does not support s390 channel I/O, s390 only performs smoke tests on
> those few devices that do not have any functional tests.  Therefore, every time we
> add functional tests for a virtio device, the choice is between removing
> those tests from the s390 suite (so that s390 actually _loses_ coverage)
> or sprinkling the test with architecture checks.
> 
> This patch simply creates a ccw-specific test that only performs smoke tests on
> all virtio-ccw devices.  If channel I/O support is ever added to qtest and libqos,
> then this file can go away.  In the meanwhile, it simplifies maintenance and
> makes sure that all virtio devices are tested.
> 
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
>  tests/Makefile.include  |   5 +-
>  tests/virtio-ccw-test.c | 118 ++++++++++++++++++++++++++++++++++++++++
>  2 files changed, 120 insertions(+), 3 deletions(-)
>  create mode 100644 tests/virtio-ccw-test.c

I'm not that familiar with qtest/libqos, but that sounds like a
reasonable approach.

Acked-by: Cornelia Huck <cohuck@redhat.com>

  reply	other threads:[~2018-08-01 13:34 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-01 13:27 [Qemu-devel] [PATCH] tests: virtio: separate ccw tests from libqos Paolo Bonzini
2018-08-01 13:34 ` Cornelia Huck [this message]
2018-08-01 16:39 ` [Qemu-devel] [qemu-s390x] " Thomas Huth
2018-08-01 16:46   ` Paolo Bonzini
  -- strict thread matches above, loose matches on Subject: below --
2018-08-21 13:02 [Qemu-devel] [PATCH rebased] " Paolo Bonzini
2018-08-21 13:02 ` [Qemu-devel] [PATCH] " Paolo Bonzini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180801153419.08e12a63.cohuck@redhat.com \
    --to=cohuck@redhat.com \
    --cc=e.emanuelegiuseppe@gmail.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-s390x@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).