qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Yuval Shaia <yuval.shaia@oracle.com>
To: qemu-devel@nongnu.org, yuval.shaia@oracle.com,
	marcel.apfelbaum@gmail.com
Subject: [Qemu-devel] [PATCH v2 13/13] hw/rdma: Add reference to pci_dev in backend_dev
Date: Sun,  5 Aug 2018 18:35:18 +0300	[thread overview]
Message-ID: <20180805153518.2983-14-yuval.shaia@oracle.com> (raw)
In-Reply-To: <20180805153518.2983-1-yuval.shaia@oracle.com>

The field backend_dev->dev is not initialized, fix it.

Signed-off-by: Yuval Shaia <yuval.shaia@oracle.com>
---
 hw/rdma/rdma_backend.c    | 6 +++++-
 hw/rdma/rdma_backend.h    | 2 +-
 hw/rdma/vmw/pvrdma_main.c | 2 +-
 3 files changed, 7 insertions(+), 3 deletions(-)

diff --git a/hw/rdma/rdma_backend.c b/hw/rdma/rdma_backend.c
index d29acc505b..d7a4bbd91f 100644
--- a/hw/rdma/rdma_backend.c
+++ b/hw/rdma/rdma_backend.c
@@ -744,7 +744,7 @@ static int init_device_caps(RdmaBackendDev *backend_dev,
     return 0;
 }
 
-int rdma_backend_init(RdmaBackendDev *backend_dev,
+int rdma_backend_init(RdmaBackendDev *backend_dev, PCIDevice *pdev,
                       RdmaDeviceResources *rdma_dev_res,
                       const char *backend_device_name, uint8_t port_num,
                       uint8_t backend_gid_idx, struct ibv_device_attr *dev_attr,
@@ -756,6 +756,10 @@ int rdma_backend_init(RdmaBackendDev *backend_dev,
     struct ibv_device **dev_list;
     struct ibv_port_attr port_attr;
 
+    memset(backend_dev, 0, sizeof(*backend_dev));
+
+    backend_dev->dev = pdev;
+
     backend_dev->backend_gid_idx = backend_gid_idx;
     backend_dev->port_num = port_num;
     backend_dev->rdma_dev_res = rdma_dev_res;
diff --git a/hw/rdma/rdma_backend.h b/hw/rdma/rdma_backend.h
index 3049a73962..86e8fe8ab6 100644
--- a/hw/rdma/rdma_backend.h
+++ b/hw/rdma/rdma_backend.h
@@ -46,7 +46,7 @@ static inline uint32_t rdma_backend_mr_rkey(const RdmaBackendMR *mr)
     return mr->ibmr ? mr->ibmr->rkey : 0;
 }
 
-int rdma_backend_init(RdmaBackendDev *backend_dev,
+int rdma_backend_init(RdmaBackendDev *backend_dev, PCIDevice *pdev,
                       RdmaDeviceResources *rdma_dev_res,
                       const char *backend_device_name, uint8_t port_num,
                       uint8_t backend_gid_idx, struct ibv_device_attr *dev_attr,
diff --git a/hw/rdma/vmw/pvrdma_main.c b/hw/rdma/vmw/pvrdma_main.c
index 3d448bffc4..ca5fa8d981 100644
--- a/hw/rdma/vmw/pvrdma_main.c
+++ b/hw/rdma/vmw/pvrdma_main.c
@@ -611,7 +611,7 @@ static void pvrdma_realize(PCIDevice *pdev, Error **errp)
         goto out;
     }
 
-    rc = rdma_backend_init(&dev->backend_dev, &dev->rdma_dev_res,
+    rc = rdma_backend_init(&dev->backend_dev, pdev, &dev->rdma_dev_res,
                            dev->backend_device_name, dev->backend_port_num,
                            dev->backend_gid_idx, &dev->dev_attr, errp);
     if (rc) {
-- 
2.17.1

  parent reply	other threads:[~2018-08-05 15:36 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-05 15:35 [Qemu-devel] [PATCH v2 00/13] Misc fixes for pvrdma device Yuval Shaia
2018-08-05 15:35 ` [Qemu-devel] [PATCH v2 01/13] hw/rdma: Make distinction between device init and start modes Yuval Shaia
2018-08-05 15:35 ` [Qemu-devel] [PATCH v2 02/13] hw/pvrdma: Bugfix - provide the correct attr_mask to query_qp Yuval Shaia
2018-08-05 15:35 ` [Qemu-devel] [PATCH v2 03/13] hw/rdma: Modify debug macros Yuval Shaia
2018-08-05 15:35 ` [Qemu-devel] [PATCH v2 04/13] hw/pvrdma: Clean CQE before use Yuval Shaia
2018-08-05 15:35 ` [Qemu-devel] [PATCH v2 05/13] hw/pvrdma: Make default pkey 0xFFFF Yuval Shaia
2018-08-05 15:35 ` [Qemu-devel] [PATCH v2 06/13] hw/rdma: Delete useless structure RdmaRmUserMR Yuval Shaia
2018-08-06 11:42   ` Marcel Apfelbaum
2018-08-05 15:35 ` [Qemu-devel] [PATCH v2 07/13] hw/rdma: Do not allocate memory for non-dma MR Yuval Shaia
2018-08-06 11:42   ` Marcel Apfelbaum
2018-08-05 15:35 ` [Qemu-devel] [PATCH v2 08/13] hw/rdma: Reorder resource cleanup Yuval Shaia
2018-08-05 15:35 ` [Qemu-devel] [PATCH v2 09/13] hw/pvrdma: Cosmetic change - indent right Yuval Shaia
2018-08-05 15:35 ` [Qemu-devel] [PATCH v2 10/13] hw/rdma: Cosmetic change - move to generic function Yuval Shaia
2018-08-05 15:35 ` [Qemu-devel] [PATCH v2 11/13] hw/rdma: Print backend QP number in hex format Yuval Shaia
2018-08-05 15:35 ` [Qemu-devel] [PATCH v2 12/13] hw/rdma: Bugfix - Support non-aligned buffers Yuval Shaia
2018-08-05 15:35 ` Yuval Shaia [this message]
2018-08-06 11:43   ` [Qemu-devel] [PATCH v2 13/13] hw/rdma: Add reference to pci_dev in backend_dev Marcel Apfelbaum

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180805153518.2983-14-yuval.shaia@oracle.com \
    --to=yuval.shaia@oracle.com \
    --cc=marcel.apfelbaum@gmail.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).