qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Yuval Shaia <yuval.shaia@oracle.com>
To: qemu-devel@nongnu.org, yuval.shaia@oracle.com,
	marcel.apfelbaum@gmail.com
Subject: [Qemu-devel] [PATCH v2 06/13] hw/rdma: Delete useless structure RdmaRmUserMR
Date: Sun,  5 Aug 2018 18:35:11 +0300	[thread overview]
Message-ID: <20180805153518.2983-7-yuval.shaia@oracle.com> (raw)
In-Reply-To: <20180805153518.2983-1-yuval.shaia@oracle.com>

The structure RdmaRmUserMR has no benefits, remove it an move all its
fields to struct RdmaRmMR.

Signed-off-by: Yuval Shaia <yuval.shaia@oracle.com>
---
 hw/rdma/rdma_backend.c |  3 +--
 hw/rdma/rdma_rm.c      | 16 ++++++++--------
 hw/rdma/rdma_rm_defs.h | 10 +++-------
 3 files changed, 12 insertions(+), 17 deletions(-)

diff --git a/hw/rdma/rdma_backend.c b/hw/rdma/rdma_backend.c
index 647e16399f..52981d652d 100644
--- a/hw/rdma/rdma_backend.c
+++ b/hw/rdma/rdma_backend.c
@@ -271,8 +271,7 @@ static int build_host_sge_array(RdmaDeviceResources *rdma_dev_res,
             return VENDOR_ERR_INVLKEY | ssge[ssge_idx].lkey;
         }
 
-        dsge->addr = (uintptr_t)mr->user_mr.host_virt + ssge[ssge_idx].addr -
-                     mr->user_mr.guest_start;
+        dsge->addr = (uintptr_t)mr->virt + ssge[ssge_idx].addr - mr->start;
         dsge->length = ssge[ssge_idx].length;
         dsge->lkey = rdma_backend_mr_lkey(&mr->backend_mr);
 
diff --git a/hw/rdma/rdma_rm.c b/hw/rdma/rdma_rm.c
index 415da15efe..7403d24674 100644
--- a/hw/rdma/rdma_rm.c
+++ b/hw/rdma/rdma_rm.c
@@ -165,15 +165,15 @@ int rdma_rm_alloc_mr(RdmaDeviceResources *dev_res, uint32_t pd_handle,
         length = TARGET_PAGE_SIZE;
         addr = g_malloc(length);
     } else {
-        mr->user_mr.host_virt = host_virt;
-        pr_dbg("host_virt=0x%p\n", mr->user_mr.host_virt);
-        mr->user_mr.length = guest_length;
+        mr->virt = host_virt;
+        pr_dbg("host_virt=0x%p\n", mr->virt);
+        mr->length = guest_length;
         pr_dbg("length=%zu\n", guest_length);
-        mr->user_mr.guest_start = guest_start;
-        pr_dbg("guest_start=0x%" PRIx64 "\n", mr->user_mr.guest_start);
+        mr->start = guest_start;
+        pr_dbg("guest_start=0x%" PRIx64 "\n", mr->start);
 
-        length = mr->user_mr.length;
-        addr = mr->user_mr.host_virt;
+        length = mr->length;
+        addr = mr->virt;
     }
 
     ret = rdma_backend_create_mr(&mr->backend_mr, &pd->backend_pd, addr, length,
@@ -214,7 +214,7 @@ void rdma_rm_dealloc_mr(RdmaDeviceResources *dev_res, uint32_t mr_handle)
 
     if (mr) {
         rdma_backend_destroy_mr(&mr->backend_mr);
-        munmap(mr->user_mr.host_virt, mr->user_mr.length);
+        munmap(mr->virt, mr->length);
         res_tbl_dealloc(&dev_res->mr_tbl, mr_handle);
     }
 }
diff --git a/hw/rdma/rdma_rm_defs.h b/hw/rdma/rdma_rm_defs.h
index 226011176d..7228151239 100644
--- a/hw/rdma/rdma_rm_defs.h
+++ b/hw/rdma/rdma_rm_defs.h
@@ -55,16 +55,12 @@ typedef struct RdmaRmCQ {
     bool notify;
 } RdmaRmCQ;
 
-typedef struct RdmaRmUserMR {
-    void *host_virt;
-    uint64_t guest_start;
-    size_t length;
-} RdmaRmUserMR;
-
 /* MR (DMA region) */
 typedef struct RdmaRmMR {
     RdmaBackendMR backend_mr;
-    RdmaRmUserMR user_mr;
+    void *virt;
+    uint64_t start;
+    size_t length;
     uint32_t pd_handle;
     uint32_t lkey;
     uint32_t rkey;
-- 
2.17.1

  parent reply	other threads:[~2018-08-05 15:36 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-05 15:35 [Qemu-devel] [PATCH v2 00/13] Misc fixes for pvrdma device Yuval Shaia
2018-08-05 15:35 ` [Qemu-devel] [PATCH v2 01/13] hw/rdma: Make distinction between device init and start modes Yuval Shaia
2018-08-05 15:35 ` [Qemu-devel] [PATCH v2 02/13] hw/pvrdma: Bugfix - provide the correct attr_mask to query_qp Yuval Shaia
2018-08-05 15:35 ` [Qemu-devel] [PATCH v2 03/13] hw/rdma: Modify debug macros Yuval Shaia
2018-08-05 15:35 ` [Qemu-devel] [PATCH v2 04/13] hw/pvrdma: Clean CQE before use Yuval Shaia
2018-08-05 15:35 ` [Qemu-devel] [PATCH v2 05/13] hw/pvrdma: Make default pkey 0xFFFF Yuval Shaia
2018-08-05 15:35 ` Yuval Shaia [this message]
2018-08-06 11:42   ` [Qemu-devel] [PATCH v2 06/13] hw/rdma: Delete useless structure RdmaRmUserMR Marcel Apfelbaum
2018-08-05 15:35 ` [Qemu-devel] [PATCH v2 07/13] hw/rdma: Do not allocate memory for non-dma MR Yuval Shaia
2018-08-06 11:42   ` Marcel Apfelbaum
2018-08-05 15:35 ` [Qemu-devel] [PATCH v2 08/13] hw/rdma: Reorder resource cleanup Yuval Shaia
2018-08-05 15:35 ` [Qemu-devel] [PATCH v2 09/13] hw/pvrdma: Cosmetic change - indent right Yuval Shaia
2018-08-05 15:35 ` [Qemu-devel] [PATCH v2 10/13] hw/rdma: Cosmetic change - move to generic function Yuval Shaia
2018-08-05 15:35 ` [Qemu-devel] [PATCH v2 11/13] hw/rdma: Print backend QP number in hex format Yuval Shaia
2018-08-05 15:35 ` [Qemu-devel] [PATCH v2 12/13] hw/rdma: Bugfix - Support non-aligned buffers Yuval Shaia
2018-08-05 15:35 ` [Qemu-devel] [PATCH v2 13/13] hw/rdma: Add reference to pci_dev in backend_dev Yuval Shaia
2018-08-06 11:43   ` Marcel Apfelbaum

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180805153518.2983-7-yuval.shaia@oracle.com \
    --to=yuval.shaia@oracle.com \
    --cc=marcel.apfelbaum@gmail.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).