* [Qemu-devel] [PATCH] tcg/optimize: Do not skip default processing of dup_vec
@ 2018-08-05 23:32 Richard Henderson
2018-08-06 5:29 ` Laurent Desnogues
0 siblings, 1 reply; 3+ messages in thread
From: Richard Henderson @ 2018-08-05 23:32 UTC (permalink / raw)
To: qemu-devel; +Cc: laurent.desnogues
If we do not opimize away dup_vec, we must mark its output as changed.
Fixes: 170ba88f45b
Reported-by: Laurent Desnogues <laurent.desnogues@gmail.com>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
tcg/optimize.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tcg/optimize.c b/tcg/optimize.c
index d4ea67e541..5dbe11c3c8 100644
--- a/tcg/optimize.c
+++ b/tcg/optimize.c
@@ -1094,9 +1094,9 @@ void tcg_optimize(TCGContext *s)
tmp = arg_info(op->args[1])->val;
tmp = dup_const(TCGOP_VECE(op), tmp);
tcg_opt_gen_movi(s, op, op->args[0], tmp);
- continue;
+ break;
}
- break;
+ goto do_default;
CASE_OP_32_64(not):
CASE_OP_32_64(neg):
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [Qemu-devel] [PATCH] tcg/optimize: Do not skip default processing of dup_vec
2018-08-05 23:32 [Qemu-devel] [PATCH] tcg/optimize: Do not skip default processing of dup_vec Richard Henderson
@ 2018-08-06 5:29 ` Laurent Desnogues
2018-08-06 14:24 ` Peter Maydell
0 siblings, 1 reply; 3+ messages in thread
From: Laurent Desnogues @ 2018-08-06 5:29 UTC (permalink / raw)
To: Richard Henderson; +Cc: qemu-devel@nongnu.org
Hello,
On Mon, Aug 6, 2018 at 1:32 AM, Richard Henderson
<richard.henderson@linaro.org> wrote:
> If we do not opimize away dup_vec, we must mark its output as changed.
>
> Fixes: 170ba88f45b
> Reported-by: Laurent Desnogues <laurent.desnogues@gmail.com>
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
Reviewed-by: Laurent Desnogues <laurent.desnogues@gmail.com>
Tested-by: Laurent Desnogues <laurent.desnogues@gmail.com>
Thanks,
Laurent
> ---
> tcg/optimize.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tcg/optimize.c b/tcg/optimize.c
> index d4ea67e541..5dbe11c3c8 100644
> --- a/tcg/optimize.c
> +++ b/tcg/optimize.c
> @@ -1094,9 +1094,9 @@ void tcg_optimize(TCGContext *s)
> tmp = arg_info(op->args[1])->val;
> tmp = dup_const(TCGOP_VECE(op), tmp);
> tcg_opt_gen_movi(s, op, op->args[0], tmp);
> - continue;
> + break;
> }
> - break;
> + goto do_default;
>
> CASE_OP_32_64(not):
> CASE_OP_32_64(neg):
> --
> 2.17.1
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH] tcg/optimize: Do not skip default processing of dup_vec
2018-08-06 5:29 ` Laurent Desnogues
@ 2018-08-06 14:24 ` Peter Maydell
0 siblings, 0 replies; 3+ messages in thread
From: Peter Maydell @ 2018-08-06 14:24 UTC (permalink / raw)
To: Laurent Desnogues; +Cc: Richard Henderson, qemu-devel@nongnu.org
On 6 August 2018 at 06:29, Laurent Desnogues
<laurent.desnogues@gmail.com> wrote:
> Hello,
>
> On Mon, Aug 6, 2018 at 1:32 AM, Richard Henderson
> <richard.henderson@linaro.org> wrote:
>> If we do not opimize away dup_vec, we must mark its output as changed.
>>
>> Fixes: 170ba88f45b
>> Reported-by: Laurent Desnogues <laurent.desnogues@gmail.com>
>> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
>
> Reviewed-by: Laurent Desnogues <laurent.desnogues@gmail.com>
> Tested-by: Laurent Desnogues <laurent.desnogues@gmail.com>
>
Applied to master for rc4, thanks.
-- PMM
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-08-06 14:24 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-08-05 23:32 [Qemu-devel] [PATCH] tcg/optimize: Do not skip default processing of dup_vec Richard Henderson
2018-08-06 5:29 ` Laurent Desnogues
2018-08-06 14:24 ` Peter Maydell
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).