From: Kevin Wolf <kwolf@redhat.com>
To: qemu-block@nongnu.org
Cc: kwolf@redhat.com, coli@redhat.com, qemu-devel@nongnu.org
Subject: [Qemu-devel] [PATCH] qapi/block: Document restrictions for node names
Date: Mon, 6 Aug 2018 14:37:28 +0200 [thread overview]
Message-ID: <20180806123728.13658-1-kwolf@redhat.com> (raw)
blockdev-add fails if an invalid node name is given, so we should
document what a valid node name even is.
Reported-by: Cong Li <coli@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
---
qapi/block-core.json | 3 +++
1 file changed, 3 insertions(+)
diff --git a/qapi/block-core.json b/qapi/block-core.json
index 62a92fa4f4..fe565ebfaf 100644
--- a/qapi/block-core.json
+++ b/qapi/block-core.json
@@ -3563,6 +3563,9 @@
# @driver: block driver name
# @node-name: the node name of the new node (Since 2.0).
# This option is required on the top level of blockdev-add.
+# Valid node names start with an alphabetic character and may
+# contain only alphanumeric characters, '-', '.' and '_'. Their
+# maximum length is 31 characters.
# @discard: discard-related options (default: ignore)
# @cache: cache-related options
# @read-only: whether the block device should be read-only (default: false).
--
2.13.6
next reply other threads:[~2018-08-06 12:37 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-06 12:37 Kevin Wolf [this message]
2018-08-06 14:19 ` [Qemu-devel] [PATCH] qapi/block: Document restrictions for node names Eric Blake
2018-08-07 2:38 ` Cong Li
2018-08-07 11:13 ` [Qemu-devel] [Qemu-block] " Alberto Garcia
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180806123728.13658-1-kwolf@redhat.com \
--to=kwolf@redhat.com \
--cc=coli@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).