From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38896) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fmelW-00054O-IA for qemu-devel@nongnu.org; Mon, 06 Aug 2018 08:37:39 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fmelV-000856-Qw for qemu-devel@nongnu.org; Mon, 06 Aug 2018 08:37:38 -0400 From: Kevin Wolf Date: Mon, 6 Aug 2018 14:37:28 +0200 Message-Id: <20180806123728.13658-1-kwolf@redhat.com> Subject: [Qemu-devel] [PATCH] qapi/block: Document restrictions for node names List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-block@nongnu.org Cc: kwolf@redhat.com, coli@redhat.com, qemu-devel@nongnu.org blockdev-add fails if an invalid node name is given, so we should document what a valid node name even is. Reported-by: Cong Li Signed-off-by: Kevin Wolf --- qapi/block-core.json | 3 +++ 1 file changed, 3 insertions(+) diff --git a/qapi/block-core.json b/qapi/block-core.json index 62a92fa4f4..fe565ebfaf 100644 --- a/qapi/block-core.json +++ b/qapi/block-core.json @@ -3563,6 +3563,9 @@ # @driver: block driver name # @node-name: the node name of the new node (Since 2.0). # This option is required on the top level of blockdev-add. +# Valid node names start with an alphabetic character and may +# contain only alphanumeric characters, '-', '.' and '_'. Their +# maximum length is 31 characters. # @discard: discard-related options (default: ignore) # @cache: cache-related options # @read-only: whether the block device should be read-only (default: false). -- 2.13.6