From: John Snow <jsnow@redhat.com>
To: qemu-devel@nongnu.org, qemu-block@nongnu.org
Cc: kwolf@redhat.com, Jeff Cody <jcody@redhat.com>,
Max Reitz <mreitz@redhat.com>,
jtc@redhat.com, Markus Armbruster <armbru@redhat.com>,
"Dr. David Alan Gilbert" <dgilbert@redhat.com>,
Eric Blake <eblake@redhat.com>, John Snow <jsnow@redhat.com>
Subject: [Qemu-devel] [PATCH 19/21] qapi/block-commit: expose new job properties
Date: Tue, 7 Aug 2018 00:33:47 -0400 [thread overview]
Message-ID: <20180807043349.27196-20-jsnow@redhat.com> (raw)
In-Reply-To: <20180807043349.27196-1-jsnow@redhat.com>
Signed-off-by: John Snow <jsnow@redhat.com>
---
blockdev.c | 8 ++++++++
qapi/block-core.json | 3 ++-
2 files changed, 10 insertions(+), 1 deletion(-)
diff --git a/blockdev.c b/blockdev.c
index c2e6402a66..8efc47e178 100644
--- a/blockdev.c
+++ b/blockdev.c
@@ -3314,6 +3314,8 @@ void qmp_block_commit(bool has_job_id, const char *job_id, const char *device,
bool has_backing_file, const char *backing_file,
bool has_speed, int64_t speed,
bool has_filter_node_name, const char *filter_node_name,
+ bool has_auto_finalize, bool auto_finalize,
+ bool has_auto_dismiss, bool auto_dismiss,
Error **errp)
{
BlockDriverState *bs;
@@ -3333,6 +3335,12 @@ void qmp_block_commit(bool has_job_id, const char *job_id, const char *device,
if (!has_filter_node_name) {
filter_node_name = NULL;
}
+ if (has_auto_finalize && !auto_finalize) {
+ job_flags |= JOB_MANUAL_FINALIZE;
+ }
+ if (has_auto_dismiss && !auto_dismiss) {
+ job_flags |= JOB_MANUAL_DISMISS;
+ }
/* Important Note:
* libvirt relies on the DeviceNotFound error class in order to probe for
diff --git a/qapi/block-core.json b/qapi/block-core.json
index 5b9084a394..4ee58cfb28 100644
--- a/qapi/block-core.json
+++ b/qapi/block-core.json
@@ -1518,7 +1518,8 @@
{ 'command': 'block-commit',
'data': { '*job-id': 'str', 'device': 'str', '*base': 'str', '*top': 'str',
'*backing-file': 'str', '*speed': 'int',
- '*filter-node-name': 'str' } }
+ '*filter-node-name': 'str',
+ '*auto-finalize': 'bool', '*auto-dismiss': 'bool' } }
##
# @drive-backup:
--
2.14.4
next prev parent reply other threads:[~2018-08-07 4:34 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-07 4:33 [Qemu-devel] [PATCH 00/21] jobs: defer graph changes until finalize John Snow
2018-08-07 4:33 ` [Qemu-devel] [PATCH 01/21] jobs: canonize Error object John Snow
2018-08-08 14:57 ` Kevin Wolf
2018-08-08 15:50 ` John Snow
2018-08-08 16:02 ` Kevin Wolf
2018-08-07 4:33 ` [Qemu-devel] [PATCH 02/21] jobs: add exit shim John Snow
2018-08-08 4:02 ` Jeff Cody
2018-08-08 13:55 ` John Snow
2018-08-08 15:23 ` Kevin Wolf
2018-08-08 15:38 ` John Snow
2018-08-08 15:47 ` Kevin Wolf
2018-08-07 4:33 ` [Qemu-devel] [PATCH 03/21] block/backup: utilize job_exit shim John Snow
2018-08-07 4:33 ` [Qemu-devel] [PATCH 04/21] block/commit: " John Snow
2018-08-08 3:41 ` Jeff Cody
2018-08-08 14:00 ` John Snow
2018-08-08 16:29 ` Kevin Wolf
2018-08-15 20:52 ` John Snow
2018-08-16 6:41 ` Kevin Wolf
2018-08-07 4:33 ` [Qemu-devel] [PATCH 05/21] block/mirror: " John Snow
2018-08-08 3:47 ` Jeff Cody
2018-08-07 4:33 ` [Qemu-devel] [PATCH 06/21] block/stream: " John Snow
2018-08-08 3:47 ` Jeff Cody
2018-08-07 4:33 ` [Qemu-devel] [PATCH 07/21] block/create: " John Snow
2018-08-07 4:33 ` [Qemu-devel] [PATCH 08/21] tests/test-blockjob-txn: " John Snow
2018-08-07 4:33 ` [Qemu-devel] [PATCH 09/21] tests/test-blockjob: " John Snow
2018-08-07 4:33 ` [Qemu-devel] [PATCH 10/21] tests/test-bdrv-drain: " John Snow
2018-08-07 4:33 ` [Qemu-devel] [PATCH 11/21] jobs: remove job_defer_to_main_loop John Snow
2018-08-07 4:33 ` [Qemu-devel] [PATCH 12/21] jobs: allow entrypoints to return status code John Snow
2018-08-07 4:33 ` [Qemu-devel] [PATCH 13/21] block/commit: add block job creation flags John Snow
2018-08-07 4:33 ` [Qemu-devel] [PATCH 14/21] block/mirror: " John Snow
2018-08-07 4:33 ` [Qemu-devel] [PATCH 15/21] block/stream: " John Snow
2018-08-07 4:33 ` [Qemu-devel] [PATCH 16/21] block/commit: refactor commit to use job callbacks John Snow
2018-08-09 15:12 ` Kevin Wolf
2018-08-09 16:22 ` [Qemu-devel] [Qemu-block] " Kevin Wolf
2018-08-15 21:17 ` [Qemu-devel] " John Snow
2018-08-16 6:52 ` Kevin Wolf
2018-08-07 4:33 ` [Qemu-devel] [PATCH 17/21] block/mirror: conservative mirror_exit refactor John Snow
2018-08-07 4:33 ` [Qemu-devel] [PATCH 18/21] block/commit: refactor stream to use job callbacks John Snow
2018-08-07 4:33 ` John Snow [this message]
2018-08-07 14:52 ` [Qemu-devel] [PATCH 19/21] qapi/block-commit: expose new job properties Eric Blake
2018-08-07 18:11 ` John Snow
2018-08-10 11:47 ` Kevin Wolf
2018-08-07 4:33 ` [Qemu-devel] [PATCH 20/21] qapi/block-mirror: " John Snow
2018-08-07 4:33 ` [Qemu-devel] [PATCH 21/21] qapi/block-stream: " John Snow
2018-08-15 14:44 ` [Qemu-devel] [Qemu-block] [PATCH 00/21] jobs: defer graph changes until finalize Peter Krempa
2018-08-15 15:00 ` Kevin Wolf
2018-08-15 15:04 ` Peter Krempa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180807043349.27196-20-jsnow@redhat.com \
--to=jsnow@redhat.com \
--cc=armbru@redhat.com \
--cc=dgilbert@redhat.com \
--cc=eblake@redhat.com \
--cc=jcody@redhat.com \
--cc=jtc@redhat.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).