From: Gerd Hoffmann <kraxel@redhat.com>
To: remy.noel@blade-group.com
Cc: qemu-devel@nongnu.org, dgilbert@redhat.com
Subject: Re: [Qemu-devel] [PATCH] secondary-vga: unregister vram on unplug.
Date: Tue, 7 Aug 2018 15:19:18 +0200 [thread overview]
Message-ID: <20180807131918.22bgcmfv2wu4bjda@sirius.home.kraxel.org> (raw)
In-Reply-To: <20180720081948.23644-1-remy.noel@blade-group.com>
On Fri, Jul 20, 2018 at 10:19:48AM +0200, remy.noel@blade-group.com wrote:
> From: "Remy Noel" <remy.noel@blade-group.com>
>
> When removing a secondary-vga device and then adding it back (or adding
> an other one), qemu aborts with:
> "RAMBlock "0000:00:02.0/vga.vram" already registered, abort!".
>
> It is caused by the vram staying registered, preventing vga replugging.
David? Does that look ok?
This balances the
vmstate_register_ram(&s->vram, s->global_vmstate ? NULL : DEVICE(obj));
call in vga_common_init(). I'm wondering whenever the manual cleanup is
actually needed in case owner is not NULL?
thanks,
Gerd
next prev parent reply other threads:[~2018-08-07 13:19 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-20 8:19 [Qemu-devel] [PATCH] secondary-vga: unregister vram on unplug remy.noel
2018-08-07 13:19 ` Gerd Hoffmann [this message]
2018-08-07 14:57 ` Dr. David Alan Gilbert
2018-08-07 15:06 ` Peter Maydell
2018-08-07 15:09 ` Dr. David Alan Gilbert
2018-08-11 19:07 ` Remy NOEL
2018-08-12 10:19 ` Paolo Bonzini
2018-08-30 11:28 ` Gerd Hoffmann
2018-10-02 11:55 ` Remy NOEL
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180807131918.22bgcmfv2wu4bjda@sirius.home.kraxel.org \
--to=kraxel@redhat.com \
--cc=dgilbert@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=remy.noel@blade-group.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).