From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52289) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fn7ui-0004Qy-5a for qemu-devel@nongnu.org; Tue, 07 Aug 2018 15:45:05 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fn7ud-0002WX-86 for qemu-devel@nongnu.org; Tue, 07 Aug 2018 15:45:04 -0400 Received: from mx3-rdu2.redhat.com ([66.187.233.73]:54498 helo=mx1.redhat.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1fn7ud-0002WC-2y for qemu-devel@nongnu.org; Tue, 07 Aug 2018 15:44:59 -0400 Date: Tue, 7 Aug 2018 22:44:56 +0300 From: "Michael S. Tsirkin" Message-ID: <20180807224033-mutt-send-email-mst@kernel.org> References: <20180807193125.30378-1-alex.williamson@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180807193125.30378-1-alex.williamson@redhat.com> Subject: Re: [Qemu-devel] [PATCH v3 0/4] Balloon inhibit enhancements, vfio restriction List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alex Williamson Cc: qemu-devel@nongnu.org, peterx@redhat.com, Cornelia Huck , kvm@vger.kernel.org, david@redhat.com On Tue, Aug 07, 2018 at 01:31:21PM -0600, Alex Williamson wrote: > v3: > - Drop "nested" term in commit log (David) > - Adopt suggested wording in ccw code (Cornelia) > - Explain balloon inhibitor usage in vfio common (Peter) > - Fix to call inhibitor prior to re-using existing containers > to avoid gap that pinning may have occurred in set container > ioctl (self) - Peter, this change is the reason I didn't > include your R-b. > - Add R-b to patches 1 & 2 > > v2: > - Use atomic ops for balloon inhibit counter (Peter) > - Allow endpoint driver opt-in for ballooning, vfio-ccw opt-in by > default, vfio-pci opt-in by device option, only allowed for mdev > devices, no support added for platform as there are no platform > mdev devices. > > See patch 3/4 for detailed explanation why ballooning and device > assignment typically don't mix. If this eventually changes, flags > on the iommu info struct or perhaps device info struct can inform > us for automatic opt-in. Thanks, > > Alex One of the issues with pass-through is that it breaks overcommit through swap. ballooning seems to offer one solution, instead of making it work this patch just attempts to block ballooning. I guess it's better than corrupting memory but I personally find this approach disappointing. > Alex Williamson (4): > balloon: Allow multiple inhibit users > kvm: Use inhibit to prevent ballooning without synchronous mmu > vfio: Inhibit ballooning based on group attachment to a container > vfio/ccw/pci: Allow devices to opt-in for ballooning > > accel/kvm/kvm-all.c | 4 +++ > balloon.c | 13 ++++++--- > hw/vfio/ccw.c | 9 +++++++ > hw/vfio/common.c | 51 +++++++++++++++++++++++++++++++++++ > hw/vfio/pci.c | 26 +++++++++++++++++- > hw/vfio/trace-events | 1 + > hw/virtio/virtio-balloon.c | 4 +-- > include/hw/vfio/vfio-common.h | 2 ++ > 8 files changed, 103 insertions(+), 7 deletions(-) > > -- > 2.18.0