From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52351) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fnNBk-0006eF-Ac for qemu-devel@nongnu.org; Wed, 08 Aug 2018 08:03:44 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fnNBg-0008Mb-5w for qemu-devel@nongnu.org; Wed, 08 Aug 2018 08:03:40 -0400 Received: from mx3-rdu2.redhat.com ([66.187.233.73]:47658 helo=mx1.redhat.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1fnNBg-0008Lp-0e for qemu-devel@nongnu.org; Wed, 08 Aug 2018 08:03:36 -0400 From: Markus Armbruster Date: Wed, 8 Aug 2018 14:02:39 +0200 Message-Id: <20180808120334.10970-2-armbru@redhat.com> In-Reply-To: <20180808120334.10970-1-armbru@redhat.com> References: <20180808120334.10970-1-armbru@redhat.com> Subject: [Qemu-devel] [PATCH 01/56] check-qjson: Cover multiple JSON objects in same string List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: marcandre.lureau@redhat.com, mdroth@linux.vnet.ibm.com, eblake@redhat.com qobject_from_json() & friends misbehave when the JSON text has more than one JSON value. Add test coverage to demonstrate the bugs. Signed-off-by: Markus Armbruster --- tests/check-qjson.c | 20 ++++++++++++++++++++ 1 file changed, 20 insertions(+) diff --git a/tests/check-qjson.c b/tests/check-qjson.c index eaf5d20663..cc952c56ea 100644 --- a/tests/check-qjson.c +++ b/tests/check-qjson.c @@ -1418,6 +1418,25 @@ static void limits_nesting(void) g_assert(obj == NULL); } +static void multiple_values(void) +{ + Error *err = NULL; + QObject *obj; + + /* BUG this leaks the syntax tree for "false" */ + obj = qobject_from_json("false true", &err); + g_assert(qbool_get_bool(qobject_to(QBool, obj))); + g_assert(!err); + qobject_unref(obj); + + /* BUG simultaneously succeeds and fails */ + /* BUG calls json_parser_parse() with errp pointing to non-null */ + obj = qobject_from_json("} true", &err); + g_assert(qbool_get_bool(qobject_to(QBool, obj))); + error_free_or_abort(&err); + qobject_unref(obj); +} + int main(int argc, char **argv) { g_test_init(&argc, &argv, NULL); @@ -1455,6 +1474,7 @@ int main(int argc, char **argv) g_test_add_func("/errors/invalid_dict_comma", invalid_dict_comma); g_test_add_func("/errors/unterminated/literal", unterminated_literal); g_test_add_func("/errors/limits/nesting", limits_nesting); + g_test_add_func("/errors/multiple_values", multiple_values); return g_test_run(); } -- 2.17.1