From: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
To: qemu-devel@nongnu.org, qemu-block@nongnu.org
Cc: pbonzini@redhat.com, eblake@redhat.com, jsnow@redhat.com,
famz@redhat.com, mreitz@redhat.com, kwolf@redhat.com,
jcody@redhat.com, vsementsov@virtuozzo.com, den@openvz.org
Subject: [Qemu-devel] [PATCH v2 0/7] dirty-bitmap: rewrite bdrv_dirty_iter_next_area
Date: Wed, 8 Aug 2018 15:49:18 +0300 [thread overview]
Message-ID: <20180808124925.21031-1-vsementsov@virtuozzo.com> (raw)
Hi all.
1. bdrv_dirty_iter_next_area don't use hbitmap_next_zero and uses
inefficient loop instead. Let's improve it.
2. bdrv_dirty_iter_next_area don't handle unaligned offset and
max_offset correctly. I'm not sure that it is a real bug. But if it is,
we need these series in 3.0.
Details are in 04 commit message.
v2:
01: - improve comment
- s/bytes/count/
- fix forgotten function call in test
- introduce orig_size field here for HBitmap,
make checking in hbitmap_next_zero more effective and safe
02: new
03: - orig_size already introduced in 01
- fix hbitmap_next_dirty_area to not return value less than
offset on unaligned requests
Vladimir Sementsov-Ogievskiy (7):
dirty-bitmap: improve bdrv_dirty_bitmap_next_zero
tests: add tests for hbitmap_next_zero with non-zero count parameter
dirty-bitmap: add bdrv_dirty_bitmap_next_dirty_area
block/mirror: fix and improve do_sync_target_write
Revert "block/dirty-bitmap: Add bdrv_dirty_iter_next_area"
Revert "test-hbitmap: Add non-advancing iter_next tests"
Revert "hbitmap: Add @advance param to hbitmap_iter_next()"
include/block/dirty-bitmap.h | 8 +++--
include/qemu/hbitmap.h | 30 ++++++++++++++----
block/backup.c | 4 +--
block/dirty-bitmap.c | 69 +++++++----------------------------------
block/mirror.c | 16 +++++-----
nbd/server.c | 2 +-
tests/test-hbitmap.c | 69 +++++++++++++++++++++++------------------
util/hbitmap.c | 73 ++++++++++++++++++++++++++++++++++++--------
8 files changed, 151 insertions(+), 120 deletions(-)
--
2.11.1
next reply other threads:[~2018-08-08 12:49 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-08 12:49 Vladimir Sementsov-Ogievskiy [this message]
2018-08-08 12:49 ` [Qemu-devel] [PATCH v2 1/7] dirty-bitmap: improve bdrv_dirty_bitmap_next_zero Vladimir Sementsov-Ogievskiy
2018-08-08 12:49 ` [Qemu-devel] [PATCH v2 2/7] tests: add tests for hbitmap_next_zero with non-zero count parameter Vladimir Sementsov-Ogievskiy
2018-08-08 12:49 ` [Qemu-devel] [PATCH v2 3/7] dirty-bitmap: add bdrv_dirty_bitmap_next_dirty_area Vladimir Sementsov-Ogievskiy
2018-08-10 17:05 ` Vladimir Sementsov-Ogievskiy
2018-08-13 15:42 ` Vladimir Sementsov-Ogievskiy
2018-08-08 12:49 ` [Qemu-devel] [PATCH v2 4/7] block/mirror: fix and improve do_sync_target_write Vladimir Sementsov-Ogievskiy
2018-08-08 12:49 ` [Qemu-devel] [PATCH v2 5/7] Revert "block/dirty-bitmap: Add bdrv_dirty_iter_next_area" Vladimir Sementsov-Ogievskiy
2018-08-08 12:49 ` [Qemu-devel] [PATCH v2 6/7] Revert "test-hbitmap: Add non-advancing iter_next tests" Vladimir Sementsov-Ogievskiy
2018-08-08 12:49 ` [Qemu-devel] [PATCH v2 7/7] Revert "hbitmap: Add @advance param to hbitmap_iter_next()" Vladimir Sementsov-Ogievskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180808124925.21031-1-vsementsov@virtuozzo.com \
--to=vsementsov@virtuozzo.com \
--cc=den@openvz.org \
--cc=eblake@redhat.com \
--cc=famz@redhat.com \
--cc=jcody@redhat.com \
--cc=jsnow@redhat.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).