From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35846) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fnqDK-0001ak-Lh for qemu-devel@nongnu.org; Thu, 09 Aug 2018 15:03:15 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fnqDH-0006Ce-Gm for qemu-devel@nongnu.org; Thu, 09 Aug 2018 15:03:14 -0400 Received: from mx3-rdu2.redhat.com ([66.187.233.73]:49848 helo=mx1.redhat.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1fnqDH-0006CA-Ax for qemu-devel@nongnu.org; Thu, 09 Aug 2018 15:03:11 -0400 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 4AEA4F2B48 for ; Thu, 9 Aug 2018 19:03:10 +0000 (UTC) Date: Thu, 9 Aug 2018 20:03:03 +0100 From: "Dr. David Alan Gilbert" Message-ID: <20180809190303.GF2618@work-vm> References: <20180808114830.7169-1-quintela@redhat.com> <20180808114830.7169-10-quintela@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180808114830.7169-10-quintela@redhat.com> Subject: Re: [Qemu-devel] [PATCH v2 09/22] virtio: Remove unneeded includes List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Juan Quintela , mst@redhat.com Cc: qemu-devel@nongnu.org, lvivier@redhat.com, peterx@redhat.com * Juan Quintela (quintela@redhat.com) wrote: > They are all already included in virtio_pci.h. > > Signed-off-by: Juan Quintela cc'ing in mst for virtio goodness. > --- > hw/virtio/virtio-pci.c | 15 +-------------- > 1 file changed, 1 insertion(+), 14 deletions(-) > > diff --git a/hw/virtio/virtio-pci.c b/hw/virtio/virtio-pci.c > index 3a01fe90f0..cb2ddd3f41 100644 > --- a/hw/virtio/virtio-pci.c > +++ b/hw/virtio/virtio-pci.c > @@ -18,24 +18,11 @@ > #include "qemu/osdep.h" > > #include "standard-headers/linux/virtio_pci.h" > -#include "hw/virtio/virtio.h" > -#include "hw/virtio/virtio-blk.h" > -#include "hw/virtio/virtio-net.h" > -#include "hw/virtio/virtio-serial.h" > -#include "hw/virtio/virtio-scsi.h" > -#include "hw/virtio/virtio-balloon.h" > -#include "hw/virtio/virtio-input.h" > -#include "hw/pci/pci.h" > +#include "virtio-pci.h" > #include "qapi/error.h" > -#include "qemu/error-report.h" > -#include "hw/pci/msi.h" > #include "hw/pci/msix.h" > -#include "hw/loader.h" > #include "sysemu/kvm.h" > -#include "virtio-pci.h" > #include "qemu/range.h" > -#include "hw/virtio/virtio-bus.h" > -#include "qapi/visitor.h" > > #define VIRTIO_PCI_REGION_SIZE(dev) VIRTIO_PCI_CONFIG_OFF(msix_present(dev)) > > -- > 2.17.1 > -- Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK