From: Yuval Shaia <yuval.shaia@oracle.com>
To: Marcel Apfelbaum <marcel.apfelbaum@gmail.com>
Cc: qemu-devel@nongnu.org, thuth@redhat.com
Subject: Re: [Qemu-devel] [PATCH] hw/pvrdma: remove not needed include
Date: Sun, 12 Aug 2018 11:39:44 +0300 [thread overview]
Message-ID: <20180812083943.GB3004@lap1> (raw)
In-Reply-To: <20180811171534.11917-1-marcel.apfelbaum@gmail.com>
On Sat, Aug 11, 2018 at 08:15:34PM +0300, Marcel Apfelbaum wrote:
> No need to include linux/types.h, is empty anyway.
>
> Suggested-by: Thomas Huth <thuth@redhat.com>
> Signed-off-by: Marcel Apfelbaum <marcel.apfelbaum@gmail.com>
> ---
> hw/rdma/vmw/pvrdma_cmd.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/hw/rdma/vmw/pvrdma_cmd.c b/hw/rdma/vmw/pvrdma_cmd.c
> index 14255d609f..3f697c8db7 100644
> --- a/hw/rdma/vmw/pvrdma_cmd.c
> +++ b/hw/rdma/vmw/pvrdma_cmd.c
> @@ -16,7 +16,6 @@
> #include "qemu/osdep.h"
> #include "qemu/error-report.h"
> #include "cpu.h"
> -#include <linux/types.h>
> #include "hw/hw.h"
> #include "hw/pci/pci.h"
> #include "hw/pci/pci_ids.h"
Reviewed-by: Yuval Shaia <yuval.shaia@oracle.com>
> --
> 2.17.1
>
prev parent reply other threads:[~2018-08-12 8:40 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-11 17:15 [Qemu-devel] [PATCH] hw/pvrdma: remove not needed include Marcel Apfelbaum
2018-08-12 8:39 ` Yuval Shaia [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180812083943.GB3004@lap1 \
--to=yuval.shaia@oracle.com \
--cc=marcel.apfelbaum@gmail.com \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).