* [Qemu-devel] [PATCH] hw/pvrdma: remove not needed include
@ 2018-08-11 17:15 Marcel Apfelbaum
2018-08-12 8:39 ` Yuval Shaia
0 siblings, 1 reply; 2+ messages in thread
From: Marcel Apfelbaum @ 2018-08-11 17:15 UTC (permalink / raw)
To: qemu-devel; +Cc: yuval.shaia, thuth
No need to include linux/types.h, is empty anyway.
Suggested-by: Thomas Huth <thuth@redhat.com>
Signed-off-by: Marcel Apfelbaum <marcel.apfelbaum@gmail.com>
---
hw/rdma/vmw/pvrdma_cmd.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/hw/rdma/vmw/pvrdma_cmd.c b/hw/rdma/vmw/pvrdma_cmd.c
index 14255d609f..3f697c8db7 100644
--- a/hw/rdma/vmw/pvrdma_cmd.c
+++ b/hw/rdma/vmw/pvrdma_cmd.c
@@ -16,7 +16,6 @@
#include "qemu/osdep.h"
#include "qemu/error-report.h"
#include "cpu.h"
-#include <linux/types.h>
#include "hw/hw.h"
#include "hw/pci/pci.h"
#include "hw/pci/pci_ids.h"
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [Qemu-devel] [PATCH] hw/pvrdma: remove not needed include
2018-08-11 17:15 [Qemu-devel] [PATCH] hw/pvrdma: remove not needed include Marcel Apfelbaum
@ 2018-08-12 8:39 ` Yuval Shaia
0 siblings, 0 replies; 2+ messages in thread
From: Yuval Shaia @ 2018-08-12 8:39 UTC (permalink / raw)
To: Marcel Apfelbaum; +Cc: qemu-devel, thuth
On Sat, Aug 11, 2018 at 08:15:34PM +0300, Marcel Apfelbaum wrote:
> No need to include linux/types.h, is empty anyway.
>
> Suggested-by: Thomas Huth <thuth@redhat.com>
> Signed-off-by: Marcel Apfelbaum <marcel.apfelbaum@gmail.com>
> ---
> hw/rdma/vmw/pvrdma_cmd.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/hw/rdma/vmw/pvrdma_cmd.c b/hw/rdma/vmw/pvrdma_cmd.c
> index 14255d609f..3f697c8db7 100644
> --- a/hw/rdma/vmw/pvrdma_cmd.c
> +++ b/hw/rdma/vmw/pvrdma_cmd.c
> @@ -16,7 +16,6 @@
> #include "qemu/osdep.h"
> #include "qemu/error-report.h"
> #include "cpu.h"
> -#include <linux/types.h>
> #include "hw/hw.h"
> #include "hw/pci/pci.h"
> #include "hw/pci/pci_ids.h"
Reviewed-by: Yuval Shaia <yuval.shaia@oracle.com>
> --
> 2.17.1
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-08-12 8:40 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-08-11 17:15 [Qemu-devel] [PATCH] hw/pvrdma: remove not needed include Marcel Apfelbaum
2018-08-12 8:39 ` Yuval Shaia
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).