From: Max Reitz <mreitz@redhat.com>
To: qemu-block@nongnu.org
Cc: qemu-devel@nongnu.org, Max Reitz <mreitz@redhat.com>,
Kevin Wolf <kwolf@redhat.com>, Jeff Cody <jcody@redhat.com>,
Fam Zheng <famz@redhat.com>
Subject: [Qemu-devel] [PATCH 11/17] mirror: Inline mirror_write_complete(), part 1
Date: Mon, 13 Aug 2018 04:20:00 +0200 [thread overview]
Message-ID: <20180813022006.7216-12-mreitz@redhat.com> (raw)
In-Reply-To: <20180813022006.7216-1-mreitz@redhat.com>
Eventually, we want to inline mirror_write_complete() fully into
mirror_co_perform(). This patch does the inlining, but we cannot remove
the function yet, as it is still required by mirror_co_read().
Signed-off-by: Max Reitz <mreitz@redhat.com>
---
block/mirror.c | 12 +++++++++++-
1 file changed, 11 insertions(+), 1 deletion(-)
diff --git a/block/mirror.c b/block/mirror.c
index 2a131d8b99..66746cf075 100644
--- a/block/mirror.c
+++ b/block/mirror.c
@@ -407,7 +407,17 @@ static void coroutine_fn mirror_co_perform(void *opaque)
abort();
}
- mirror_write_complete(op, ret);
+ if (ret < 0) {
+ BlockErrorAction action;
+
+ bdrv_set_dirty_bitmap(s->dirty_bitmap, op->offset, op->bytes);
+ action = mirror_error_action(s, false, -ret);
+ if (action == BLOCK_ERROR_ACTION_REPORT && s->ret >= 0) {
+ s->ret = ret;
+ }
+ }
+
+ mirror_iteration_done(op, ret);
done:
aio_context_release(aio_context);
--
2.17.1
next prev parent reply other threads:[~2018-08-13 2:20 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-13 2:19 [Qemu-devel] [PATCH 00/17] mirror: Mainly coroutine refinements Max Reitz
2018-08-13 2:19 ` [Qemu-devel] [PATCH 01/17] iotests: Try reading while mirroring in 156 Max Reitz
2018-08-14 3:39 ` Jeff Cody
2018-08-13 2:19 ` [Qemu-devel] [PATCH 02/17] mirror: Make wait_for_any_operation() coroutine_fn Max Reitz
2018-08-13 12:54 ` Murilo Opsfelder Araujo
2018-08-13 15:20 ` Max Reitz
2018-08-14 3:36 ` Jeff Cody
2018-08-13 2:19 ` [Qemu-devel] [PATCH 03/17] mirror: Pull *_align_for_copy() from *_co_read() Max Reitz
2018-08-14 3:39 ` Jeff Cody
2018-08-13 2:19 ` [Qemu-devel] [PATCH 04/17] mirror: Remove bytes_handled, part 1 Max Reitz
2018-08-13 2:19 ` [Qemu-devel] [PATCH 05/17] mirror: Remove bytes_handled, part 2 Max Reitz
2018-08-13 2:19 ` [Qemu-devel] [PATCH 06/17] mirror: Create mirror_co_perform() Max Reitz
2018-08-13 2:19 ` [Qemu-devel] [PATCH 07/17] mirror: Make mirror_co_zero() nicer Max Reitz
2018-08-13 2:19 ` [Qemu-devel] [PATCH 08/17] mirror: Make mirror_co_discard() nicer Max Reitz
2018-08-13 2:19 ` [Qemu-devel] [PATCH 09/17] mirror: Lock AioContext in mirror_co_perform() Max Reitz
2018-08-13 14:43 ` [Qemu-devel] [Qemu-block] " Paolo Bonzini
2018-08-13 15:21 ` Max Reitz
2018-08-13 2:19 ` [Qemu-devel] [PATCH 10/17] mirror: Create mirror_co_alloc_qiov() Max Reitz
2018-08-13 2:20 ` Max Reitz [this message]
2018-08-13 2:20 ` [Qemu-devel] [PATCH 12/17] mirror: Put QIOV locally into mirror_co_read Max Reitz
2018-08-13 2:20 ` [Qemu-devel] [PATCH 13/17] mirror: Linearize mirror_co_read() Max Reitz
2018-08-13 2:20 ` [Qemu-devel] [PATCH 14/17] mirror: Inline mirror_iteration_done() Max Reitz
2018-08-13 2:20 ` [Qemu-devel] [PATCH 15/17] mirror: Release AioCtx before queue_restart_all() Max Reitz
2018-08-13 2:20 ` [Qemu-devel] [PATCH 16/17] mirror: Support COR with write-blocking Max Reitz
2018-08-13 2:20 ` [Qemu-devel] [PATCH 17/17] iotests: Add test for active mirror with COR Max Reitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180813022006.7216-12-mreitz@redhat.com \
--to=mreitz@redhat.com \
--cc=famz@redhat.com \
--cc=jcody@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).