From: Kevin Wolf <kwolf@redhat.com>
To: Max Reitz <mreitz@redhat.com>
Cc: Leonid Bloch <lbloch@janustech.com>,
Alberto Garcia <berto@igalia.com>,
qemu-devel@nongnu.org, qemu-block@nongnu.org,
Eric Blake <eblake@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v7 6/9] qcow2: Increase the default upper limit on the L2 cache size
Date: Mon, 13 Aug 2018 18:00:25 +0200 [thread overview]
Message-ID: <20180813160025.GM4323@localhost.localdomain> (raw)
In-Reply-To: <572652c3-bb11-4158-c3ec-8dc786fd2ae8@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 1639 bytes --]
Am 13.08.2018 um 17:16 hat Max Reitz geschrieben:
> On 2018-08-13 08:09, Leonid Bloch wrote:
> > On August 13, 2018 4:39:35 AM EEST, Max Reitz <mreitz@redhat.com> wrote:
>
> [...]
>
> >> Ideally we'd probably want a soft and a hard cache limit, but I don't
> >> know...
> >>
> >> (Like, a soft cache limit of 1 MB with a CCI of 10 min, and a hard
> >> cache
> >> limit of 32 MB with a CCI of 1 min by default. So whenever your cache
> >> uses more than 1 MB of RAM, your CCI is 1 min, and whenever it's below,
> >> your CCI is 10 min.)
> >
> > Max, thanks for your insight. Indeed some good points.
> > Considering this, I'm thinking to set the limit to 16 MB, and the CCI to 5 min. What do you think?
>
> I think it's good for a preliminary solution, and then later increase
> the limit with the soft and hard limits.
>
> OTOH, if we implement the soft/hard limits, it doesn't really matter
> what default you choose now...
>
> > Modern Windows installations should gain performance from being able to random I/O to >8 GB chunks, and data processing tasks where each data set is 8+ GB for sure do (did benchmarks). And the maximum is only ever used if (a) the image is large enough and (b) it is indeed used.
> > While taking 256 GB images as the "limit" can be considered an overshoot, 128 GB is quite reasonable, I think.
> >
> > Your idea with "soft" and "hard" limits is great! I'm tempted to implement this. Say 4 MB with 10 min., and 16 MB with 5 min?
>
> 32 MB and 2 or 3 min? :-)
>
> If you do that, I'm fine with a plain default of 32 MB for now.
I would be happy with that.
Kevin
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 801 bytes --]
next prev parent reply other threads:[~2018-08-13 16:00 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-10 6:26 [Qemu-devel] [PATCH v7 0/9] Take the image size into account when allocating the L2 cache Leonid Bloch
2018-08-10 6:26 ` [Qemu-devel] [PATCH v7 1/9] qcow2: Options' documentation fixes Leonid Bloch
2018-08-10 11:50 ` Alberto Garcia
2018-08-11 18:01 ` Leonid Bloch
2018-08-10 6:26 ` [Qemu-devel] [PATCH v7 2/9] qcow2: Cosmetic changes Leonid Bloch
2018-08-10 12:54 ` Alberto Garcia
2018-08-10 6:26 ` [Qemu-devel] [PATCH v7 3/9] qcow2: Make sizes more humanly readable Leonid Bloch
2018-08-10 8:33 ` Alberto Garcia
2018-08-10 6:26 ` [Qemu-devel] [PATCH v7 4/9] qcow2: Avoid duplication in setting the refcount cache size Leonid Bloch
2018-08-10 13:14 ` Alberto Garcia
2018-08-11 18:40 ` Leonid Bloch
2018-08-10 6:26 ` [Qemu-devel] [PATCH v7 5/9] qcow2: Assign the L2 cache relatively to the image size Leonid Bloch
2018-08-10 14:39 ` Alberto Garcia
2018-08-11 19:19 ` Leonid Bloch
2018-08-13 11:33 ` Kevin Wolf
2018-08-13 11:48 ` Leonid Bloch
2018-08-10 6:26 ` [Qemu-devel] [PATCH v7 6/9] qcow2: Increase the default upper limit on the L2 cache size Leonid Bloch
2018-08-10 12:00 ` Alberto Garcia
2018-08-13 1:39 ` Max Reitz
2018-08-13 6:09 ` Leonid Bloch
2018-08-13 15:16 ` Max Reitz
2018-08-13 16:00 ` Kevin Wolf [this message]
2018-08-13 11:23 ` Kevin Wolf
2018-08-13 15:11 ` Max Reitz
2018-08-13 15:58 ` Kevin Wolf
2018-08-13 16:08 ` Max Reitz
2018-08-13 16:24 ` Kevin Wolf
2018-08-13 16:42 ` Leonid Bloch
2018-08-14 8:18 ` Kevin Wolf
2018-08-14 11:34 ` Leonid Bloch
2018-08-14 11:44 ` Kevin Wolf
2018-08-14 12:29 ` Leonid Bloch
2018-08-10 6:26 ` [Qemu-devel] [PATCH v7 7/9] qcow2: Resize the cache upon image resizing Leonid Bloch
2018-08-10 6:26 ` [Qemu-devel] [PATCH v7 8/9] qcow2: Set the default cache-clean-interval to 10 minutes Leonid Bloch
2018-08-10 6:26 ` [Qemu-devel] [PATCH v7 9/9] qcow2: Explicit number replaced by a constant Leonid Bloch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180813160025.GM4323@localhost.localdomain \
--to=kwolf@redhat.com \
--cc=berto@igalia.com \
--cc=eblake@redhat.com \
--cc=lbloch@janustech.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).