From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: Frank Yang <lfy@google.com>,
Peter Maydell <peter.maydell@linaro.org>,
qemu-devel <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] RAMBlocks and memory_region_init_ram_nomigrate
Date: Mon, 13 Aug 2018 17:45:34 +0100 [thread overview]
Message-ID: <20180813164533.GF2488@work-vm> (raw)
In-Reply-To: <8487b7ec-271c-4ba1-b1f8-539635943603@redhat.com>
* Paolo Bonzini (pbonzini@redhat.com) wrote:
> On 13/08/2018 18:16, Frank Yang wrote:
> > Hi Paolo,
> >
> > I see that migration/ram.c saves RAMBlocks associated with memory
> > regions initialized with nomigrate. Is this intended?
>
> Probably the name and size of the RAMBlocks must match but the contents
> need not (but honestly I haven't looked at the code to find the answer).
> CCing the qemu mailing list (always a good idea) and a couple people
> that might know.
All the migration code should now be using RAMBLOCK_FOREACH_MIGRATABLE and
qemu_ram_is_migratable whenever it's iterating the ramblock list,
so that *shouldn't* happen these days.
Of course we could have messed it up somewhere; what are you seeing?
Dave
> Paolo
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK
next prev parent reply other threads:[~2018-08-13 16:45 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CAEkmjvUix62F8EK9pHboRZOcpycCgMapiqVNM976UVkv-B6u5g@mail.gmail.com>
2018-08-13 16:27 ` [Qemu-devel] RAMBlocks and memory_region_init_ram_nomigrate Paolo Bonzini
2018-08-13 16:30 ` Peter Maydell
2018-08-13 16:45 ` Dr. David Alan Gilbert [this message]
2018-08-13 21:06 ` Frank Yang
2018-08-14 8:16 ` Dr. David Alan Gilbert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180813164533.GF2488@work-vm \
--to=dgilbert@redhat.com \
--cc=lfy@google.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).