From: "Emilio G. Cota" <cota@braap.org>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: qemu-devel@nongnu.org,
"Peter Crosthwaite" <crosthwaite.peter@gmail.com>,
"Richard Henderson" <rth@twiddle.net>,
"Eduardo Habkost" <ehabkost@redhat.com>,
"Michael S . Tsirkin" <mst@redhat.com>,
"Marcel Apfelbaum" <marcel.apfelbaum@gmail.com>,
"Alex Bennée" <alex.bennee@linaro.org>
Subject: Re: [Qemu-devel] [PATCH 3/4] target/i386/translate: use thread-local storage in !user-mode
Date: Tue, 14 Aug 2018 03:34:12 -0400 [thread overview]
Message-ID: <20180814073412.GA32086@flamenco> (raw)
In-Reply-To: <5a55a78e-d4f2-2528-481c-9eda97718f81@redhat.com>
On Tue, Aug 14, 2018 at 08:31:02 +0200, Paolo Bonzini wrote:
> On 14/08/2018 03:38, Emilio G. Cota wrote:
> > Needed for MTTCG.
> >
> > Signed-off-by: Emilio G. Cota <cota@braap.org>
>
> Why not always use TLS, even in user-mode?
To avoid TLS waste; user-mode uses a single TCGContext,
so a single copy of these variables is all that's needed because
code generation is serialized with a lock.
If in user-mode we just have a few threads it'd be no big deal,
but apps can easily spawn thousands of threads.
E.
next prev parent reply other threads:[~2018-08-14 7:34 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-14 1:37 [Qemu-devel] [PATCH 0/4] x86_64 mttcg Emilio G. Cota
2018-08-14 1:37 ` [Qemu-devel] [PATCH 1/4] hw/i386/pc: hold the BQL when calling cpu_get_ticks Emilio G. Cota
2018-08-14 6:37 ` Paolo Bonzini
2018-08-14 1:37 ` [Qemu-devel] [PATCH 2/4] cpus: assert that the BQL is held in cpu_get_ticks Emilio G. Cota
2018-08-14 1:38 ` [Qemu-devel] [PATCH 3/4] target/i386/translate: use thread-local storage in !user-mode Emilio G. Cota
2018-08-14 6:31 ` Paolo Bonzini
2018-08-14 7:34 ` Emilio G. Cota [this message]
2018-08-14 1:38 ` [Qemu-devel] [PATCH 4/4] configure: enable mttcg for x86_64 Emilio G. Cota
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180814073412.GA32086@flamenco \
--to=cota@braap.org \
--cc=alex.bennee@linaro.org \
--cc=crosthwaite.peter@gmail.com \
--cc=ehabkost@redhat.com \
--cc=marcel.apfelbaum@gmail.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).