From: Kevin Wolf <kwolf@redhat.com>
To: qemu-block@nongnu.org
Cc: kwolf@redhat.com, peter.maydell@linaro.org, qemu-devel@nongnu.org
Subject: [Qemu-devel] [PULL 10/21] block: Remove dead deprecation warning code
Date: Wed, 15 Aug 2018 14:55:26 +0200 [thread overview]
Message-ID: <20180815125537.10651-11-kwolf@redhat.com> (raw)
In-Reply-To: <20180815125537.10651-1-kwolf@redhat.com>
This reinstates commit 6266e900b8083945cb766b45c124fb3c42932cb3,
which was temporarily reverted for the 3.0 release so that libvirt gets
some extra time to update their command lines.
We removed all options from the 'deprecated' array, so the code is dead
and can be removed as well.
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
Reviewed-by: Markus Armbruster <armbru@redhat.com>
---
blockdev.c | 12 ------------
1 file changed, 12 deletions(-)
diff --git a/blockdev.c b/blockdev.c
index 37eb40670b..72f5347df5 100644
--- a/blockdev.c
+++ b/blockdev.c
@@ -775,8 +775,6 @@ DriveInfo *drive_new(QemuOpts *all_opts, BlockInterfaceType block_default_type)
const char *filename;
Error *local_err = NULL;
int i;
- const char *deprecated[] = {
- };
/* Change legacy command line options into QMP ones */
static const struct {
@@ -853,16 +851,6 @@ DriveInfo *drive_new(QemuOpts *all_opts, BlockInterfaceType block_default_type)
goto fail;
}
- /* Other deprecated options */
- if (!qtest_enabled()) {
- for (i = 0; i < ARRAY_SIZE(deprecated); i++) {
- if (qemu_opt_get(legacy_opts, deprecated[i]) != NULL) {
- error_report("'%s' is deprecated, please use the corresponding "
- "option of '-device' instead", deprecated[i]);
- }
- }
- }
-
/* Media type */
value = qemu_opt_get(legacy_opts, "media");
if (value) {
--
2.13.6
next prev parent reply other threads:[~2018-08-15 12:56 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-15 12:55 [Qemu-devel] [PULL 00/21] Block layer patches Kevin Wolf
2018-08-15 12:55 ` [Qemu-devel] [PULL 01/21] block/qapi: Fix memory leak in qmp_query_blockstats() Kevin Wolf
2018-08-15 12:55 ` [Qemu-devel] [PULL 02/21] qemu-iotests: Test removing a throttle group member with a pending timer Kevin Wolf
2018-08-15 12:55 ` [Qemu-devel] [PULL 03/21] throttle-groups: Skip the round-robin if a member is being drained Kevin Wolf
2018-08-15 12:55 ` [Qemu-devel] [PULL 04/21] qemu-iotests: Update 093 to improve the draining test Kevin Wolf
2018-08-15 12:55 ` [Qemu-devel] [PULL 05/21] throttle-groups: Don't allow timers without throttled requests Kevin Wolf
2018-08-15 12:55 ` [Qemu-devel] [PULL 06/21] luks: Allow share-rw=on Kevin Wolf
2018-08-15 12:55 ` [Qemu-devel] [PULL 07/21] block: Remove deprecated -drive geometry options Kevin Wolf
2018-08-15 12:55 ` [Qemu-devel] [PULL 08/21] block: Remove deprecated -drive option addr Kevin Wolf
2018-08-15 12:55 ` [Qemu-devel] [PULL 09/21] block: Remove deprecated -drive option serial Kevin Wolf
2018-08-15 12:55 ` Kevin Wolf [this message]
2018-08-15 12:55 ` [Qemu-devel] [PULL 11/21] qapi/block: Document restrictions for node names Kevin Wolf
2018-08-15 12:55 ` [Qemu-devel] [PULL 12/21] mirror: Fail gracefully for source == target Kevin Wolf
2018-08-15 12:55 ` [Qemu-devel] [PULL 13/21] qemu-img: fix regression copying secrets during convert Kevin Wolf
2018-08-15 12:55 ` [Qemu-devel] [PULL 14/21] block: make .bdrv_close optional Kevin Wolf
2018-08-15 12:55 ` [Qemu-devel] [PULL 15/21] block: drop empty .bdrv_close handlers Kevin Wolf
2018-08-15 12:55 ` [Qemu-devel] [PULL 16/21] qdict: Make qdict_extract_subqdict() accept dst = NULL Kevin Wolf
2018-08-15 12:55 ` [Qemu-devel] [PULL 17/21] block: Remove children options from bs->{options, explicit_options} Kevin Wolf
2018-08-15 12:55 ` [Qemu-devel] [PULL 18/21] block: Simplify bdrv_reopen_abort() Kevin Wolf
2018-08-15 12:55 ` [Qemu-devel] [PULL 19/21] block: Update bs->options if bdrv_reopen() succeeds Kevin Wolf
2018-08-15 12:55 ` [Qemu-devel] [PULL 20/21] block: Simplify append_open_options() Kevin Wolf
2018-08-15 12:55 ` [Qemu-devel] [PULL 21/21] qapi: block: Remove mentions of error types which were removed Kevin Wolf
2018-08-16 8:50 ` [Qemu-devel] [PULL 00/21] Block layer patches Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180815125537.10651-11-kwolf@redhat.com \
--to=kwolf@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).