qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Peter Xu <peterx@redhat.com>
To: Thomas Huth <thuth@redhat.com>
Cc: qemu-devel@nongnu.org,
	"Dr . David Alan Gilbert" <dgilbert@redhat.com>,
	"Markus Armbruster" <armbru@redhat.com>,
	"Marc-André Lureau" <marcandre.lureau@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v6 11/13] tests: remove "0.15" prefix for test-qmp-cmds
Date: Thu, 16 Aug 2018 09:55:04 +0800	[thread overview]
Message-ID: <20180816015504.GE2708@xz-mi> (raw)
In-Reply-To: <82ab9863-6c03-ccbe-e2d1-b03dcc8c636b@redhat.com>

On Wed, Aug 15, 2018 at 03:48:57PM +0200, Thomas Huth wrote:
> On 08/15/2018 03:37 PM, Peter Xu wrote:
> > The "0.15" prefix seems useless.  Remove them.
> > 
> > Signed-off-by: Peter Xu <peterx@redhat.com>
> > ---
> >  tests/test-qmp-cmds.c | 10 +++++-----
> >  1 file changed, 5 insertions(+), 5 deletions(-)
> > 
> > diff --git a/tests/test-qmp-cmds.c b/tests/test-qmp-cmds.c
> > index ba41a6161e..989819b26d 100644
> > --- a/tests/test-qmp-cmds.c
> > +++ b/tests/test-qmp-cmds.c
> > @@ -286,11 +286,11 @@ int main(int argc, char **argv)
> >  {
> >      g_test_init(&argc, &argv, NULL);
> >  
> > -    g_test_add_func("/0.15/dispatch_cmd", test_dispatch_cmd);
> > -    g_test_add_func("/0.15/dispatch_cmd_failure", test_dispatch_cmd_failure);
> > -    g_test_add_func("/0.15/dispatch_cmd_io", test_dispatch_cmd_io);
> > -    g_test_add_func("/0.15/dealloc_types", test_dealloc_types);
> > -    g_test_add_func("/0.15/dealloc_partial", test_dealloc_partial);
> > +    g_test_add_func("/dispatch_cmd", test_dispatch_cmd);
> > +    g_test_add_func("/dispatch_cmd_failure", test_dispatch_cmd_failure);
> > +    g_test_add_func("/dispatch_cmd_io", test_dispatch_cmd_io);
> > +    g_test_add_func("/dealloc_types", test_dealloc_types);
> > +    g_test_add_func("/dealloc_partial", test_dealloc_partial);
> 
> Most other tests use a common prefix, so maybe rather replace the "0.15"
> with "qmp-cmd" here? E.g.:
> 
>  g_test_add_func("/qmp-cmd/dispatch_cmd", test_dispatch_cmd);
> 
> ?

I'll drop this patch due to a dup in master.  That one has "/qmp"
prefix.  Thanks Thomas.

-- 
Peter Xu

  reply	other threads:[~2018-08-16  1:55 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-15 13:37 [Qemu-devel] [PATCH v6 00/13] monitor: enable OOB by default Peter Xu
2018-08-15 13:37 ` [Qemu-devel] [PATCH v6 01/13] monitor: simplify monitor_qmp_setup_handlers_bh Peter Xu
2018-08-21 18:13   ` Marc-André Lureau
2018-08-22  4:38     ` Peter Xu
2018-08-27 11:29   ` Markus Armbruster
2018-08-28  3:26     ` Peter Xu
2018-08-15 13:37 ` [Qemu-devel] [PATCH v6 02/13] qapi: Fix build_params() for empty parameter list Peter Xu
2018-08-15 13:37 ` [Qemu-devel] [PATCH v6 03/13] qapi: remove error checks for event emission Peter Xu
2018-08-27 12:14   ` Markus Armbruster
2018-08-28  3:31     ` Peter Xu
2018-08-30 14:05     ` Markus Armbruster
2018-08-15 13:37 ` [Qemu-devel] [PATCH v6 04/13] monitor: move need_resume flag into monitor struct Peter Xu
2018-08-15 13:37 ` [Qemu-devel] [PATCH v6 05/13] monitor: suspend monitor instead of send CMD_DROP Peter Xu
2018-08-15 13:37 ` [Qemu-devel] [PATCH v6 06/13] qapi: remove COMMAND_DROPPED event Peter Xu
2018-08-27 19:30   ` Eric Blake
2018-08-28  3:38     ` Peter Xu
2018-08-15 13:37 ` [Qemu-devel] [PATCH v6 07/13] monitor: restrict response queue length too Peter Xu
2018-08-15 13:37 ` [Qemu-devel] [PATCH v6 08/13] monitor: remove "x-oob", turn oob on by default Peter Xu
2018-08-15 13:37 ` [Qemu-devel] [PATCH v6 09/13] Revert "tests: Add parameter to qtest_init_without_qmp_handshake" Peter Xu
2018-08-15 13:37 ` [Qemu-devel] [PATCH v6 10/13] monitor: add traces for qmp queues Peter Xu
2018-08-15 13:37 ` [Qemu-devel] [PATCH v6 11/13] tests: remove "0.15" prefix for test-qmp-cmds Peter Xu
2018-08-15 13:48   ` Thomas Huth
2018-08-16  1:55     ` Peter Xu [this message]
2018-08-15 18:11   ` Marc-André Lureau
2018-08-16  1:51     ` Peter Xu
2018-08-16  7:20       ` Markus Armbruster
2018-08-15 13:37 ` [Qemu-devel] [PATCH v6 12/13] tests: add oob functional test " Peter Xu
2018-08-15 13:37 ` [Qemu-devel] [PATCH v6 13/13] monitor: reduce different code path for oob Peter Xu
2018-08-28 19:05 ` [Qemu-devel] [PATCH v6 00/13] monitor: enable OOB by default Markus Armbruster

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180816015504.GE2708@xz-mi \
    --to=peterx@redhat.com \
    --cc=armbru@redhat.com \
    --cc=dgilbert@redhat.com \
    --cc=marcandre.lureau@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).