From: Marcel Apfelbaum <marcel.apfelbaum@gmail.com>
To: qemu-devel@nongnu.org, peter.maydell@linaro.org
Cc: yuval.shaia@oracle.com, thuth@redhat.com, marcel.apfelbaum@gmail.com
Subject: [Qemu-devel] [PATCH PULL 03/15] hw/rdma: Modify debug macros
Date: Sun, 19 Aug 2018 23:22:48 +0300 [thread overview]
Message-ID: <20180819202300.10590-4-marcel.apfelbaum@gmail.com> (raw)
In-Reply-To: <20180819202300.10590-1-marcel.apfelbaum@gmail.com>
From: Yuval Shaia <yuval.shaia@oracle.com>
- Add line counter to ease navigation in log
- Print rdma instead of pvrdma
Signed-off-by: Yuval Shaia <yuval.shaia@oracle.com>
Reviewed-by: Marcel Apfelbaum <marcel.apfelbaum@gmail.com>
Message-Id: <20180805153518.2983-4-yuval.shaia@oracle.com>
Signed-off-by: Marcel Apfelbaum <marcel.apfelbaum@gmail.com>
---
hw/rdma/rdma_utils.c | 4 ++++
hw/rdma/rdma_utils.h | 16 ++++++++++++----
hw/rdma/vmw/pvrdma_main.c | 2 ++
3 files changed, 18 insertions(+), 4 deletions(-)
diff --git a/hw/rdma/rdma_utils.c b/hw/rdma/rdma_utils.c
index d713f635f1..dc23f158f3 100644
--- a/hw/rdma/rdma_utils.c
+++ b/hw/rdma/rdma_utils.c
@@ -15,6 +15,10 @@
#include "rdma_utils.h"
+#ifdef PVRDMA_DEBUG
+unsigned long pr_dbg_cnt;
+#endif
+
void *rdma_pci_dma_map(PCIDevice *dev, dma_addr_t addr, dma_addr_t plen)
{
void *p;
diff --git a/hw/rdma/rdma_utils.h b/hw/rdma/rdma_utils.h
index 3dc07891bc..04c7c2ef5b 100644
--- a/hw/rdma/rdma_utils.h
+++ b/hw/rdma/rdma_utils.h
@@ -22,18 +22,26 @@
#include "sysemu/dma.h"
#define pr_info(fmt, ...) \
- fprintf(stdout, "%s: %-20s (%3d): " fmt, "pvrdma", __func__, __LINE__,\
+ fprintf(stdout, "%s: %-20s (%3d): " fmt, "rdma", __func__, __LINE__,\
## __VA_ARGS__)
#define pr_err(fmt, ...) \
- fprintf(stderr, "%s: Error at %-20s (%3d): " fmt, "pvrdma", __func__, \
+ fprintf(stderr, "%s: Error at %-20s (%3d): " fmt, "rdma", __func__, \
__LINE__, ## __VA_ARGS__)
#ifdef PVRDMA_DEBUG
+extern unsigned long pr_dbg_cnt;
+
+#define init_pr_dbg(void) \
+{ \
+ pr_dbg_cnt = 0; \
+}
+
#define pr_dbg(fmt, ...) \
- fprintf(stdout, "%s: %-20s (%3d): " fmt, "pvrdma", __func__, __LINE__,\
- ## __VA_ARGS__)
+ fprintf(stdout, "%lx %ld: %-20s (%3d): " fmt, pthread_self(), pr_dbg_cnt++, \
+ __func__, __LINE__, ## __VA_ARGS__)
#else
+#define init_pr_dbg(void)
#define pr_dbg(fmt, ...)
#endif
diff --git a/hw/rdma/vmw/pvrdma_main.c b/hw/rdma/vmw/pvrdma_main.c
index 6a5073974d..1b1330e113 100644
--- a/hw/rdma/vmw/pvrdma_main.c
+++ b/hw/rdma/vmw/pvrdma_main.c
@@ -577,6 +577,8 @@ static void pvrdma_realize(PCIDevice *pdev, Error **errp)
Object *memdev_root;
bool ram_shared = false;
+ init_pr_dbg();
+
pr_dbg("Initializing device %s %x.%x\n", pdev->name,
PCI_SLOT(pdev->devfn), PCI_FUNC(pdev->devfn));
--
2.17.1
next prev parent reply other threads:[~2018-08-20 12:45 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-19 20:22 [Qemu-devel] [PATCH PULL 00/15] RDMA queue Marcel Apfelbaum
2018-08-19 20:22 ` [Qemu-devel] [PATCH PULL 01/15] hw/rdma: Make distinction between device init and start modes Marcel Apfelbaum
2018-08-19 20:22 ` [Qemu-devel] [PATCH PULL 02/15] hw/pvrdma: Bugfix - provide the correct attr_mask to query_qp Marcel Apfelbaum
2018-08-19 20:22 ` Marcel Apfelbaum [this message]
2018-08-19 20:22 ` [Qemu-devel] [PATCH PULL 04/15] hw/pvrdma: Clean CQE before use Marcel Apfelbaum
2018-08-19 20:22 ` [Qemu-devel] [PATCH PULL 05/15] hw/pvrdma: Make default pkey 0xFFFF Marcel Apfelbaum
2018-08-19 20:22 ` [Qemu-devel] [PATCH PULL 06/15] hw/rdma: Delete useless structure RdmaRmUserMR Marcel Apfelbaum
2018-08-19 20:22 ` [Qemu-devel] [PATCH PULL 07/15] hw/rdma: Do not allocate memory for non-dma MR Marcel Apfelbaum
2018-08-19 20:22 ` [Qemu-devel] [PATCH PULL 08/15] hw/rdma: Reorder resource cleanup Marcel Apfelbaum
2018-08-19 20:22 ` [Qemu-devel] [PATCH PULL 09/15] hw/pvrdma: Cosmetic change - indent right Marcel Apfelbaum
2018-08-19 20:22 ` [Qemu-devel] [PATCH PULL 10/15] hw/rdma: Cosmetic change - move to generic function Marcel Apfelbaum
2018-08-19 20:22 ` [Qemu-devel] [PATCH PULL 11/15] hw/rdma: Print backend QP number in hex format Marcel Apfelbaum
2018-08-19 20:22 ` [Qemu-devel] [PATCH PULL 12/15] hw/rdma: Bugfix - Support non-aligned buffers Marcel Apfelbaum
2018-08-19 20:22 ` [Qemu-devel] [PATCH PULL 13/15] hw/rdma: Add reference to pci_dev in backend_dev Marcel Apfelbaum
2018-08-19 20:22 ` [Qemu-devel] [PATCH PULL 14/15] hw/pvrdma: remove not needed include Marcel Apfelbaum
2018-08-19 20:23 ` [Qemu-devel] [PATCH PULL 15/15] config: split PVRDMA from RDMA Marcel Apfelbaum
2018-08-20 16:00 ` [Qemu-devel] [PATCH PULL 00/15] RDMA queue Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180819202300.10590-4-marcel.apfelbaum@gmail.com \
--to=marcel.apfelbaum@gmail.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
--cc=yuval.shaia@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).