qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Gerd Hoffmann <kraxel@redhat.com>
To: qemu-devel@nongnu.org
Cc: Gerd Hoffmann <kraxel@redhat.com>, Bandan Das <bsd@redhat.com>
Subject: [Qemu-devel] [PULL 7/7] dev-mtp: rename x-root to rootdir
Date: Tue, 21 Aug 2018 11:11:48 +0200	[thread overview]
Message-ID: <20180821091148.32220-8-kraxel@redhat.com> (raw)
In-Reply-To: <20180821091148.32220-1-kraxel@redhat.com>

From: Bandan Das <bsd@redhat.com>

x-root was renamed as such owing to the experimental nature of the
property; the underlying filesystem semantics were undecided

Signed-off-by: Bandan Das <bsd@redhat.com>
Message-id: 20180720214020.22897-6-bsd@redhat.com
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
---
 hw/usb/dev-mtp.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/hw/usb/dev-mtp.c b/hw/usb/dev-mtp.c
index 2e3ea58da6..3fdc4b0da1 100644
--- a/hw/usb/dev-mtp.c
+++ b/hw/usb/dev-mtp.c
@@ -2018,7 +2018,7 @@ static void usb_mtp_realize(USBDevice *dev, Error **errp)
     QTAILQ_INIT(&s->objects);
     if (s->desc == NULL) {
         if (s->root == NULL) {
-            error_setg(errp, "usb-mtp: x-root property must be configured");
+            error_setg(errp, "usb-mtp: rootdir property must be configured");
             return;
         }
         s->desc = strrchr(s->root, '/');
@@ -2047,7 +2047,7 @@ static const VMStateDescription vmstate_usb_mtp = {
 };
 
 static Property mtp_properties[] = {
-    DEFINE_PROP_STRING("x-root", MTPState, root),
+    DEFINE_PROP_STRING("rootdir", MTPState, root),
     DEFINE_PROP_STRING("desc", MTPState, desc),
     DEFINE_PROP_BOOL("readonly", MTPState, readonly, true),
     DEFINE_PROP_END_OF_LIST(),
-- 
2.9.3

  parent reply	other threads:[~2018-08-21  9:12 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-21  9:11 [Qemu-devel] [PULL 0/7] Usb 20180821 patches Gerd Hoffmann
2018-08-21  9:11 ` [Qemu-devel] [PULL 1/7] docs/usb2.txt: ehci has six ports Gerd Hoffmann
2018-08-21  9:11 ` [Qemu-devel] [PULL 2/7] ohci: Clear the interrupt counter for erroneous transfers Gerd Hoffmann
2018-08-21  9:11 ` [Qemu-devel] [PULL 3/7] dev-mtp: add support for canceling transaction Gerd Hoffmann
2018-08-21  9:11 ` [Qemu-devel] [PULL 4/7] dev-mtp: fix buffer allocation for writing file contents Gerd Hoffmann
2018-08-21  9:11 ` [Qemu-devel] [PULL 5/7] dev-mtp: retry write for incomplete transfers Gerd Hoffmann
2018-08-21  9:11 ` [Qemu-devel] [PULL 6/7] dev-mtp: Add support for > 4GB file transfers Gerd Hoffmann
2018-08-21  9:11 ` Gerd Hoffmann [this message]
2018-08-23  9:19 ` [Qemu-devel] [PULL 0/7] Usb 20180821 patches Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180821091148.32220-8-kraxel@redhat.com \
    --to=kraxel@redhat.com \
    --cc=bsd@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).