qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Eduardo Otubo <otubo@redhat.com>
To: "Alex Bennée" <alex.bennee@linaro.org>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [RFC PATCH 2/3] qemu-seccomp: manually expand SCMP_A1
Date: Tue, 21 Aug 2018 14:06:34 +0200	[thread overview]
Message-ID: <20180821120634.GC3923@vader> (raw)
In-Reply-To: <20180810171102.16451-3-alex.bennee@linaro.org>

[-- Attachment #1: Type: text/plain, Size: 759 bytes --]

On 10/08/2018 - 18:11:00, Alex Bennée wrote:
> The expansion of ((struct scmp_arg_cmp){1, SCMP_CMP_NE, 5}) doesn't
> work with -std=gnu99.
> 
> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
> ---
>  qemu-seccomp.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/qemu-seccomp.c b/qemu-seccomp.c
> index 9cd8eb9499..4dc1c22924 100644
> --- a/qemu-seccomp.c
> +++ b/qemu-seccomp.c
> @@ -39,7 +39,7 @@ struct QemuSeccompSyscall {
>  };
>  
>  const struct scmp_arg_cmp sched_setscheduler_arg[] = {
> -    SCMP_A1(SCMP_CMP_NE, SCHED_IDLE)
> +    {1, SCMP_CMP_NE, SCHED_IDLE}
>  };
>  
>  static const struct QemuSeccompSyscall blacklist[] = {
> -- 
> 2.17.1
> 
Acked-by: Eduardo Otubo <otubo@redhat.com>

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 455 bytes --]

  reply	other threads:[~2018-08-21 12:13 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-10 17:10 [Qemu-devel] [RFC PATCH 0/3] tweaks for QEMU's C standard Alex Bennée
2018-08-10 17:10 ` [Qemu-devel] [RFC PATCH 1/3] HACKING: mention the C GNU extensions we use Alex Bennée
2018-08-10 17:11 ` [Qemu-devel] [RFC PATCH 2/3] qemu-seccomp: manually expand SCMP_A1 Alex Bennée
2018-08-21 12:06   ` Eduardo Otubo [this message]
2018-08-10 17:11 ` [Qemu-devel] [RFC PATCH 3/3] .travis.yml: ensure we support C99 on old compilers Alex Bennée
2018-08-10 17:24   ` Philippe Mathieu-Daudé
2018-08-13  9:07 ` [Qemu-devel] [RFC PATCH 0/3] tweaks for QEMU's C standard Daniel P. Berrangé
2018-08-13  9:18   ` Daniel P. Berrangé
2018-08-13  9:29     ` Peter Maydell
2018-08-13  9:52     ` Alex Bennée
2018-08-13  9:25   ` Thomas Huth
2018-08-13 11:03     ` Daniel P. Berrangé

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180821120634.GC3923@vader \
    --to=otubo@redhat.com \
    --cc=alex.bennee@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).