From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46722) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fs7R4-0001Oz-Sh for qemu-devel@nongnu.org; Tue, 21 Aug 2018 10:15:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fs7R0-0000jO-US for qemu-devel@nongnu.org; Tue, 21 Aug 2018 10:15:06 -0400 Received: from mx3-rdu2.redhat.com ([66.187.233.73]:38692 helo=mx1.redhat.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1fs7R0-0000ir-LQ for qemu-devel@nongnu.org; Tue, 21 Aug 2018 10:15:02 -0400 Date: Tue, 21 Aug 2018 15:14:56 +0100 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Message-ID: <20180821141456.GR7370@redhat.com> Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= References: <20180817135224.22971-1-marcandre.lureau@redhat.com> <20180820024504.GA7953@xz-mi> <20180821062951.GE19915@xz-mi> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 0/4] Fix socket chardev regression List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?utf-8?Q?Marc-Andr=C3=A9?= Lureau Cc: Peter Xu , Paolo Bonzini , QEMU On Tue, Aug 21, 2018 at 04:04:45PM +0200, Marc-Andr=C3=A9 Lureau wrote: > Hi >=20 > On Tue, Aug 21, 2018 at 8:29 AM Peter Xu wrote: > > I fully agree that current way is not ideal since basically the > > backend should not depend on the frontend, but now we have the > > gcontext as an exception then the backend will somehow depend on the > > frontend. If you don't like the way I proposed, another thing I am > > thinking is that whether we can assign the gcontext for the chardev > > backend before initialization of it (or by parsing the backend & > > frontend relationships before init of backends), then we assure that > > we never change the gcontext of any chardev backends. Though that >=20 > Yes, I think that's a cleaner solution. I suggested to use an iothread > argument in the cover letter. >=20 > Paolo, Daniel, any opinion? Never changing the GContext once initialized is much nicer. I think I had suggested that before when this code was first proposed. Regards, Daniel --=20 |: https://berrange.com -o- https://www.flickr.com/photos/dberran= ge :| |: https://libvirt.org -o- https://fstop138.berrange.c= om :| |: https://entangle-photo.org -o- https://www.instagram.com/dberran= ge :|