From: "Emilio G. Cota" <cota@braap.org>
To: Richard Henderson <richard.henderson@linaro.org>
Cc: qemu-devel@nongnu.org, pbonzini@redhat.com
Subject: Re: [Qemu-devel] [PATCH v2 1/5] tcg: Split CONFIG_ATOMIC128
Date: Tue, 21 Aug 2018 17:30:23 -0400 [thread overview]
Message-ID: <20180821213023.GA29425@flamenco> (raw)
In-Reply-To: <20180821142704.18783-2-richard.henderson@linaro.org>
On Tue, Aug 21, 2018 at 07:27:00 -0700, Richard Henderson wrote:
(snip)
> +++ b/accel/tcg/atomic_template.h
(snip)
> +#else
> +/* Fallback definitions that must be optimized away, or error. */
> +Int128 __attribute__((error("unsupported atomic")))
> + atomic16_read(Int128 *ptr);
> +Int128 __attribute__((error("unsupported atomic")))
> + atomic16_set(Int128 *ptr, Int128 val);
void return type.
Other than that,
Reviewed-by: Emilio G. Cota <cota@braap.org>
next prev parent reply other threads:[~2018-08-21 21:40 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-21 14:26 [Qemu-devel] [PATCH v2 0/5] tcg: Reorg 128-bit atomic operations Richard Henderson
2018-08-21 14:27 ` [Qemu-devel] [PATCH v2 1/5] tcg: Split CONFIG_ATOMIC128 Richard Henderson
2018-08-21 21:30 ` Emilio G. Cota [this message]
2018-08-21 14:27 ` [Qemu-devel] [PATCH v2 2/5] target/i386: Convert to HAVE_CMPXCHG128 Richard Henderson
2018-08-21 14:27 ` [Qemu-devel] [PATCH v2 3/5] target/arm: " Richard Henderson
2018-08-21 14:27 ` [Qemu-devel] [PATCH v2 4/5] target/arm: Check HAVE_CMPXCHG128 at transate time Richard Henderson
2018-08-21 22:01 ` Emilio G. Cota
2018-08-21 14:27 ` [Qemu-devel] [PATCH v2 5/5] target/ppc: Convert to HAVE_CMPXCHG128 and HAVE_ATOMIC128 Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180821213023.GA29425@flamenco \
--to=cota@braap.org \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).