From: Laurent Vivier <laurent@vivier.eu>
To: qemu-devel@nongnu.org
Cc: Riku Voipio <riku.voipio@iki.fi>,
Laurent Vivier <laurent@vivier.eu>,
Richard Henderson <richard.henderson@linaro.org>
Subject: [Qemu-devel] [PULL 5/7] linux-user: Propagate goto unimplemented_nowarn to return
Date: Wed, 22 Aug 2018 03:14:15 +0200 [thread overview]
Message-ID: <20180822011417.11608-6-laurent@vivier.eu> (raw)
In-Reply-To: <20180822011417.11608-1-laurent@vivier.eu>
From: Richard Henderson <richard.henderson@linaro.org>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Reviewed-by: Laurent Vivier <laurent@vivier.eu>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
Message-Id: <20180818190118.12911-6-richard.henderson@linaro.org>
Signed-off-by: Laurent Vivier <laurent@vivier.eu>
---
linux-user/syscall.c | 11 ++++-------
1 file changed, 4 insertions(+), 7 deletions(-)
diff --git a/linux-user/syscall.c b/linux-user/syscall.c
index 19e98cc0e5..6e63f15ca1 100644
--- a/linux-user/syscall.c
+++ b/linux-user/syscall.c
@@ -11976,7 +11976,7 @@ static abi_long do_syscall1(void *cpu_env, int num, abi_long arg1,
return 0;
}
#else
- goto unimplemented_nowarn;
+ return -TARGET_ENOSYS;
#endif
#endif
#ifdef TARGET_NR_get_thread_area
@@ -11989,12 +11989,12 @@ static abi_long do_syscall1(void *cpu_env, int num, abi_long arg1,
return ts->tp_value;
}
#else
- goto unimplemented_nowarn;
+ return -TARGET_ENOSYS;
#endif
#endif
#ifdef TARGET_NR_getdomainname
case TARGET_NR_getdomainname:
- goto unimplemented_nowarn;
+ return -TARGET_ENOSYS;
#endif
#ifdef TARGET_NR_clock_settime
@@ -12079,7 +12079,7 @@ static abi_long do_syscall1(void *cpu_env, int num, abi_long arg1,
* holding a mutex that is shared with another process via
* shared memory).
*/
- goto unimplemented_nowarn;
+ return -TARGET_ENOSYS;
#endif
#if defined(TARGET_NR_utimensat)
@@ -12739,9 +12739,6 @@ static abi_long do_syscall1(void *cpu_env, int num, abi_long arg1,
default:
unimplemented:
qemu_log_mask(LOG_UNIMP, "Unsupported syscall: %d\n", num);
-#if defined(TARGET_NR_setxattr) || defined(TARGET_NR_get_thread_area) || defined(TARGET_NR_getdomainname) || defined(TARGET_NR_set_robust_list)
- unimplemented_nowarn:
-#endif
return -TARGET_ENOSYS;
}
fail:
--
2.17.1
next prev parent reply other threads:[~2018-08-22 1:14 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-22 1:14 [Qemu-devel] [PULL 0/7] Linux user for 3.1 patches Laurent Vivier
2018-08-22 1:14 ` [Qemu-devel] [PULL 1/7] linux-user: Remove DEBUG Laurent Vivier
2018-08-22 1:14 ` [Qemu-devel] [PULL 2/7] linux-user: Split out do_syscall1 Laurent Vivier
2018-08-22 1:14 ` [Qemu-devel] [PULL 3/7] linux-user: Relax single exit from "break" Laurent Vivier
2018-08-22 1:14 ` [Qemu-devel] [PULL 4/7] linux-user: Propagate goto efault to return Laurent Vivier
2018-08-22 1:14 ` Laurent Vivier [this message]
2018-08-22 1:14 ` [Qemu-devel] [PULL 6/7] linux-user: Propagate goto unimplemented to default Laurent Vivier
2018-08-22 1:14 ` [Qemu-devel] [PULL 7/7] linux-user: Propagate goto fail to return Laurent Vivier
2018-08-23 12:40 ` [Qemu-devel] [PULL 0/7] Linux user for 3.1 patches Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180822011417.11608-6-laurent@vivier.eu \
--to=laurent@vivier.eu \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=riku.voipio@iki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).