From: Alex Williamson <alex.williamson@redhat.com>
To: Christian Borntraeger <borntraeger@de.ibm.com>
Cc: qemu-devel@nongnu.org, qemu-s390x <qemu-s390x@nongnu.org>,
Peter Maydell <peter.maydell@linaro.org>
Subject: Re: [Qemu-devel] [PULL 1/4] balloon: Allow multiple inhibit users
Date: Wed, 22 Aug 2018 11:47:09 -0600 [thread overview]
Message-ID: <20180822114709.1710d6c5@t450s.home> (raw)
In-Reply-To: <482037fb-60d0-eb3b-a798-4ce5f478bd69@de.ibm.com>
On Wed, 22 Aug 2018 17:56:12 +0200
Christian Borntraeger <borntraeger@de.ibm.com> wrote:
> This breaks qemu-io test for me.
>
> #0 0x000003ff98f3e2d4 in raise () at /lib64/libc.so.6
> #1 0x000003ff98f239a8 in abort () at /lib64/libc.so.6
> #2 0x000003ff98f3632e in __assert_fail_base () at /lib64/libc.so.6
> #3 0x000003ff98f363ac in () at /lib64/libc.so.6
> #4 0x000000000108301a in qemu_balloon_inhibit (state=state@entry=false) at /home/cborntra/REPOS/qemu/balloon.c:56
> #5 0x00000000012026f2 in postcopy_ram_incoming_cleanup (mis=mis@entry=0x163bc5c0) at /home/cborntra/REPOS/qemu/migration/postcopy-ram.c:542
> #6 0x00000000011eed5e in process_incoming_migration_co (opaque=<optimized out>) at /home/cborntra/REPOS/qemu/migration/migration.c:407
> #7 0x0000000001374000 in coroutine_trampoline (i0=<optimized out>, i1=<optimized out>) at /home/cborntra/REPOS/qemu/util/coroutine-ucontext.c:116
> #8 0x000003ff98f53c02 in __makecontext_ret () at /lib64/libc.so.6
>
> Cant see right now whats wrong.
I'd have to guess it's the assert added to verify increments and
decrements are balanced, which suggests postcopy is de-inhibiting more
than it's inhibiting :-\ Thanks,
Alex
next prev parent reply other threads:[~2018-08-22 17:53 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-17 17:08 [Qemu-devel] [PULL 0/4] VFIO update 2018-08-17 Alex Williamson
2018-08-17 17:08 ` [Qemu-devel] [PULL 1/4] balloon: Allow multiple inhibit users Alex Williamson
2018-08-22 15:56 ` Christian Borntraeger
2018-08-22 17:47 ` Alex Williamson [this message]
2018-08-22 19:01 ` Alex Williamson
2018-08-23 8:10 ` Cornelia Huck
2018-08-17 17:08 ` [Qemu-devel] [PULL 2/4] kvm: Use inhibit to prevent ballooning without synchronous mmu Alex Williamson
2018-08-17 17:08 ` [Qemu-devel] [PULL 3/4] vfio: Inhibit ballooning based on group attachment to a container Alex Williamson
2018-08-17 17:08 ` [Qemu-devel] [PULL 4/4] vfio/ccw/pci: Allow devices to opt-in for ballooning Alex Williamson
2018-08-20 14:23 ` Peter Maydell
2018-08-20 14:55 ` Alex Williamson
2018-08-20 8:47 ` [Qemu-devel] [PULL 0/4] VFIO update 2018-08-17 Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180822114709.1710d6c5@t450s.home \
--to=alex.williamson@redhat.com \
--cc=borntraeger@de.ibm.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-s390x@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).