qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Cornelia Huck <cohuck@redhat.com>
To: "Daniel P. Berrangé" <berrange@redhat.com>
Cc: qemu-devel@nongnu.org, Peter Maydell <peter.maydell@linaro.org>
Subject: Re: [Qemu-devel] [PATCH] scripts: report on author emails that are mangled by the mailing list
Date: Thu, 23 Aug 2018 12:33:33 +0200	[thread overview]
Message-ID: <20180823123333.7f1d8dc8.cohuck@redhat.com> (raw)
In-Reply-To: <20180823102502.28122-1-berrange@redhat.com>

On Thu, 23 Aug 2018 11:25:02 +0100
Daniel P. Berrangé <berrange@redhat.com> wrote:

> In some cases the Author: email address in patches submitted to the
> list gets mangled such that it says
> 
>     John Doe via Qemu-devel <qemu-devel@nongnu.org>
> 
> This change is a result of workarounds for DMARC policies.
> 
> Subsystem maintainers accepting patches need to catch these and fix
> them before sending pull requests, so a checkpatch.pl test is highly
> desirable.
> 
> Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
> ---
>  scripts/checkpatch.pl | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> index 42e1c50dd8..be2114a179 100755
> --- a/scripts/checkpatch.pl
> +++ b/scripts/checkpatch.pl
> @@ -1402,6 +1402,10 @@ sub process {
>  			$is_patch = 1;
>  		}
>  
> +		if ($line =~ /^Author: .*via Qemu-devel.*<qemu-devel\@nongnu.org>/) {
> +		    ERROR("Author email address is mangled by the mailing list\n" . $herecurr);
> +		}
> +
>  #check the patch for a signoff:
>  		if ($line =~ /^\s*signed-off-by:/i) {
>  			# This is a signoff, if ugly, so do not double report.

Acked-by: Cornelia Huck <cohuck@redhat.com>

  reply	other threads:[~2018-08-23 10:33 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-23 10:25 [Qemu-devel] [PATCH] scripts: report on author emails that are mangled by the mailing list Daniel P. Berrangé
2018-08-23 10:33 ` Cornelia Huck [this message]
2018-08-23 10:41 ` Peter Maydell
2018-08-23 10:59   ` Daniel P. Berrangé
2018-08-23 16:18   ` Markus Armbruster
2018-08-23 14:07 ` Eric Blake
2018-10-19 11:22 ` Daniel P. Berrangé
2018-10-19 12:00   ` Paolo Bonzini
2018-10-19 12:13     ` Daniel P. Berrangé

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180823123333.7f1d8dc8.cohuck@redhat.com \
    --to=cohuck@redhat.com \
    --cc=berrange@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).