From: "Marc-André Lureau" <marcandre.lureau@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Paolo Bonzini" <pbonzini@redhat.com>,
berrange@redhat.com, peterx@redhat.com,
"Marc-André Lureau" <marcandre.lureau@redhat.com>
Subject: [Qemu-devel] [PATCH v2 1/5] Revert "chardev: tcp: postpone TLS work until machine done"
Date: Thu, 23 Aug 2018 16:31:21 +0200 [thread overview]
Message-ID: <20180823143125.16767-2-marcandre.lureau@redhat.com> (raw)
In-Reply-To: <20180823143125.16767-1-marcandre.lureau@redhat.com>
This reverts commit 99f2f54174a595e3ada6e4332fcd2b37ebb0d55d.
See next commit reverting 25679e5d58e258e9950685ffbd0cae4cd40d9cc2 as
well for rationale.
Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
---
chardev/char-socket.c | 10 ----------
1 file changed, 10 deletions(-)
diff --git a/chardev/char-socket.c b/chardev/char-socket.c
index efbad6ee7c..e28d2cca4c 100644
--- a/chardev/char-socket.c
+++ b/chardev/char-socket.c
@@ -32,7 +32,6 @@
#include "qapi/error.h"
#include "qapi/clone-visitor.h"
#include "qapi/qapi-visit-sockets.h"
-#include "sysemu/sysemu.h"
#include "chardev/char-io.h"
@@ -724,11 +723,6 @@ static void tcp_chr_tls_init(Chardev *chr)
Error *err = NULL;
gchar *name;
- if (!machine_init_done) {
- /* This will be postponed to machine_done notifier */
- return;
- }
-
if (s->is_listen) {
tioc = qio_channel_tls_new_server(
s->ioc, s->tls_creds,
@@ -1169,10 +1163,6 @@ static int tcp_chr_machine_done_hook(Chardev *chr)
tcp_chr_connect_async(chr);
}
- if (s->ioc && s->tls_creds) {
- tcp_chr_tls_init(chr);
- }
-
return 0;
}
--
2.18.0.547.g1d89318c48
next prev parent reply other threads:[~2018-08-23 14:31 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-23 14:31 [Qemu-devel] [PATCH v2 0/5] Fix socket chardev regression Marc-André Lureau
2018-08-23 14:31 ` Marc-André Lureau [this message]
2018-08-23 14:31 ` [Qemu-devel] [PATCH v2 2/5] Revert "chardev: tcp: postpone async connection setup" Marc-André Lureau
2018-08-23 14:31 ` [Qemu-devel] [PATCH v2 3/5] char-socket: update all ioc handlers when changing context Marc-André Lureau
2018-08-23 14:31 ` [Qemu-devel] [PATCH v2 4/5] test-char: fix random socket test failure Marc-André Lureau
2018-09-11 13:46 ` Paolo Bonzini
2018-08-23 14:31 ` [Qemu-devel] [PATCH v2 5/5] test-char: add socket reconnect test Marc-André Lureau
2018-08-24 3:45 ` [Qemu-devel] [PATCH v2 0/5] Fix socket chardev regression Peter Xu
2018-08-24 8:32 ` Marc-André Lureau
2018-08-24 8:44 ` Peter Xu
2018-08-24 8:51 ` Marc-André Lureau
2018-08-24 9:12 ` Peter Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180823143125.16767-2-marcandre.lureau@redhat.com \
--to=marcandre.lureau@redhat.com \
--cc=berrange@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peterx@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).