From: Eduardo Habkost <ehabkost@redhat.com>
To: Robert Hoo <robert.hu@linux.intel.com>
Cc: robert.hu@intel.com, pbonzini@redhat.com, rth@twiddle.net,
thomas.lendacky@amd.com, qemu-devel@nongnu.org,
jingqi.liu@intel.com
Subject: Re: [Qemu-devel] [PATCH v3 2/3] kvm: Add support to KVM_GET_MSR_FEATURE_INDEX_LIST and KVM_GET_MSRS system ioctl
Date: Thu, 23 Aug 2018 14:11:58 -0300 [thread overview]
Message-ID: <20180823171158.GI3778@localhost.localdomain> (raw)
In-Reply-To: <1535005708.4104.34.camel@linux.intel.com>
On Thu, Aug 23, 2018 at 02:28:28PM +0800, Robert Hoo wrote:
> On Sat, 2018-08-18 at 12:05 -0300, Eduardo Habkost wrote:
[...]
> > We don't want QEMU to refuse to run if the kernel doesn't have
> > KVM_CAP_GET_MSR_FEATURES. We can treat missing capability as
> > equivalent to returning an empty list of MSRs.
> Yes. I'll let caller (kvm_arch_init) ignore the return value but a
> simple warning.
Warnings tend to be ignored and are generally a sign that QEMU
isn't doing the right thing. Sometimes we have no choice, but I
don't think that's the case here.
As far as I can see, we have only two possibilities here:
1) The host can run a VM that behaves exactly as requested on the
command-line (no warning required).
2) The host can't run the requested configuration (fatal error,
not a warning).
--
Eduardo
next prev parent reply other threads:[~2018-08-23 17:12 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-10 14:06 [Qemu-devel] [PATCH v3 0/3] x86: QEMU side support on MSR based features Robert Hoo
2018-08-10 14:06 ` [Qemu-devel] [PATCH v3 1/3] x86: Data structure changes to support " Robert Hoo
2018-08-17 3:10 ` Eduardo Habkost
2018-08-18 3:10 ` Robert Hoo
2018-08-18 5:48 ` Robert Hoo
2018-08-18 7:50 ` Paolo Bonzini
2018-08-17 15:50 ` Paolo Bonzini
2018-08-17 15:55 ` Eduardo Habkost
2018-08-17 17:34 ` Paolo Bonzini
2018-08-17 17:48 ` [Qemu-devel] X86CPU "feature-words" property on QEMU (was Re: [PATCH v3 1/3] x86: Data structure changes to support MSR based) features Eduardo Habkost
2018-08-17 17:59 ` Paolo Bonzini
2018-08-17 18:10 ` Eduardo Habkost
2018-08-10 14:06 ` [Qemu-devel] [PATCH v3 2/3] kvm: Add support to KVM_GET_MSR_FEATURE_INDEX_LIST and KVM_GET_MSRS system ioctl Robert Hoo
2018-08-17 13:18 ` Eduardo Habkost
2018-08-18 7:27 ` Robert Hoo
2018-08-18 15:05 ` Eduardo Habkost
2018-08-23 6:28 ` Robert Hoo
2018-08-23 17:11 ` Eduardo Habkost [this message]
2018-08-23 17:28 ` Paolo Bonzini
2018-08-23 17:36 ` Eduardo Habkost
2018-08-23 20:23 ` Paolo Bonzini
2018-08-25 17:27 ` Eduardo Habkost
2018-08-30 4:22 ` Robert Hoo
2018-08-30 18:28 ` Eduardo Habkost
2018-08-10 14:06 ` [Qemu-devel] [PATCH v3 3/3] Change other funcitons referring to feature_word_info[] Robert Hoo
2018-08-10 15:17 ` Eric Blake
2018-08-14 10:06 ` Robert Hoo
2018-08-17 13:28 ` Eduardo Habkost
2018-08-18 9:01 ` Robert Hoo
2018-08-18 15:10 ` Eduardo Habkost
2018-08-17 15:52 ` Paolo Bonzini
2018-08-18 12:53 ` Robert Hoo
2018-09-05 5:47 ` Robert Hoo
2018-09-05 14:10 ` Eduardo Habkost
2018-09-05 15:32 ` Eric Blake
2018-09-05 16:44 ` Eduardo Habkost
2018-09-05 17:41 ` Eric Blake
2018-09-06 6:00 ` Hu, Robert
2018-09-10 17:38 ` Eduardo Habkost
2018-09-11 1:44 ` Robert Hoo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180823171158.GI3778@localhost.localdomain \
--to=ehabkost@redhat.com \
--cc=jingqi.liu@intel.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=robert.hu@intel.com \
--cc=robert.hu@linux.intel.com \
--cc=rth@twiddle.net \
--cc=thomas.lendacky@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).