Re: [Qemu-devel] [PATCH v6 01/13] monitor: simplify monitor_qmp_setup_handlers_bh

[Peter Xu <peterx@redhat.com>]

On Mon, Aug 27, 2018 at 01:29:29PM +0200, Markus Armbruster wrote:
> > @@ -4624,15 +4624,10 @@ static void monitor_qmp_setup_handlers_bh(void *opaque)
> >      Monitor *mon = opaque;
> >      GMainContext *context;
> >  
> > -    if (mon->use_io_thread) {
> > -        /* Use @mon_iothread context */
> > -        context = monitor_get_io_context();
> > -        assert(context);
> > -    } else {
> > -        /* Use default main loop context */
> > -        context = NULL;
> > -    }
> > -
> > +    assert(mon->use_io_thread);
> > +    /* Use @mon_iothread context */
> 
> Mind if I drop this comment?

Yes, please.

> 
> > +    context = monitor_get_io_context();
> > +    assert(context);
> >      qemu_chr_fe_set_handlers(&mon->chr, monitor_can_read, monitor_qmp_read,
> >                               monitor_qmp_event, NULL, mon, context, true);
> >      monitor_list_append(mon);
> 
> R-by stands, of course.

Regards,

-- 
Peter Xu