qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Markus Armbruster <armbru@redhat.com>
To: qemu-devel@nongnu.org
Cc: mdroth@linux.vnet.ibm.com, eblake@redhat.com
Subject: [Qemu-devel] [PATCH 1/2] qapi: Emit a blank line before dummy declaration
Date: Tue, 28 Aug 2018 14:07:35 +0200	[thread overview]
Message-ID: <20180828120736.32323-2-armbru@redhat.com> (raw)
In-Reply-To: <20180828120736.32323-1-armbru@redhat.com>

We emit a dummy variable in each .c file "to shut up OSX toolchain
warnings about empty .o files" (commit 252dc3105fc).  Separate it from
the code preceding it (if any) with a blank line.

Signed-off-by: Markus Armbruster <armbru@redhat.com>
---
 scripts/qapi/common.py | 1 +
 1 file changed, 1 insertion(+)

diff --git a/scripts/qapi/common.py b/scripts/qapi/common.py
index 02c5c6767a..5bbf1c353d 100644
--- a/scripts/qapi/common.py
+++ b/scripts/qapi/common.py
@@ -2220,6 +2220,7 @@ class QAPIGenC(QAPIGenCCode):
 
     def _bottom(self, fname):
         return mcgen('''
+
 /* Dummy declaration to prevent empty .o file */
 char dummy_%(name)s;
 ''',
-- 
2.17.1

  reply	other threads:[~2018-08-28 12:09 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-28 12:07 [Qemu-devel] [PATCH 0/2] qapi: A whitespace touch-up, and a doc update Markus Armbruster
2018-08-28 12:07 ` Markus Armbruster [this message]
2018-08-28 12:07 ` [Qemu-devel] [PATCH 2/2] qapi: Update docs for generator changes since commit 9ee86b85267 Markus Armbruster
2018-08-28 15:12 ` [Qemu-devel] [PATCH 0/2] qapi: A whitespace touch-up, and a doc update Eric Blake
2018-08-28 19:06 ` Markus Armbruster

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180828120736.32323-2-armbru@redhat.com \
    --to=armbru@redhat.com \
    --cc=eblake@redhat.com \
    --cc=mdroth@linux.vnet.ibm.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).