qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Marc-André Lureau" <marcandre.lureau@redhat.com>
To: qemu-devel@nongnu.org
Cc: armbru@redhat.com, peterx@redhat.com,
	"Marc-André Lureau" <marcandre.lureau@redhat.com>
Subject: [Qemu-devel] [PATCH v4 07/10] tests: add qmp/qom-set-without-value test
Date: Wed, 29 Aug 2018 15:40:40 +0200	[thread overview]
Message-ID: <20180829134043.31706-8-marcandre.lureau@redhat.com> (raw)
In-Reply-To: <20180829134043.31706-1-marcandre.lureau@redhat.com>

test_qom_set_without_value() is about a bug in infrastructure used by
the QMP core, fixed in commit c489780203.  We covered the bug in
infrastructure unit tests (commit bce3035a44).  I wrote that test
earlier, to cover QMP level as well, the test could go into qmp-test.

Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
---
 tests/qmp-test.c | 18 ++++++++++++++++++
 1 file changed, 18 insertions(+)

diff --git a/tests/qmp-test.c b/tests/qmp-test.c
index 4ae2245484..fdfe73b6d2 100644
--- a/tests/qmp-test.c
+++ b/tests/qmp-test.c
@@ -348,6 +348,23 @@ static void test_qmp_preconfig(void)
     qtest_quit(qs);
 }
 
+static void test_qom_set_without_value(void)
+{
+    QTestState *qts;
+    QDict *ret;
+
+    qts = qtest_init(common_args);
+
+    ret = qtest_qmp(qts, "{'execute': 'qom-set', 'arguments':"
+                    " { 'path': '/machine', 'property': 'rtc-time' } }");
+    g_assert_nonnull(ret);
+
+    g_assert_cmpstr(get_error_class(ret), ==, "GenericError");
+
+    qobject_unref(ret);
+    qtest_quit(qts);
+}
+
 int main(int argc, char *argv[])
 {
     g_test_init(&argc, &argv, NULL);
@@ -355,6 +372,7 @@ int main(int argc, char *argv[])
     qtest_add_func("qmp/protocol", test_qmp_protocol);
     qtest_add_func("qmp/oob", test_qmp_oob);
     qtest_add_func("qmp/preconfig", test_qmp_preconfig);
+    qtest_add_func("qmp/qom-set-without-value", test_qom_set_without_value);
 
     return g_test_run();
 }
-- 
2.19.0.rc0.48.gb9dfa238d5

  parent reply	other threads:[~2018-08-29 13:41 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-29 13:40 [Qemu-devel] [PATCH v4 00/10] monitor: various code simplification and fixes Marc-André Lureau
2018-08-29 13:40 ` [Qemu-devel] [PATCH v4 01/10] monitor: consitify qmp_send_response() QDict argument Marc-André Lureau
2018-08-29 13:40 ` [Qemu-devel] [PATCH v4 02/10] qmp: constify qmp_is_oob() Marc-André Lureau
2018-08-29 13:40 ` [Qemu-devel] [PATCH v4 03/10] Revert "qmp: isolate responses into io thread" Marc-André Lureau
2018-08-29 13:40 ` [Qemu-devel] [PATCH v4 04/10] monitor: no need to save need_resume Marc-André Lureau
2018-08-29 13:40 ` [Qemu-devel] [PATCH v4 05/10] json-lexer: make it safe to call destroy multiple times Marc-André Lureau
2018-08-30 12:16   ` Markus Armbruster
2018-08-29 13:40 ` [Qemu-devel] [PATCH v4 06/10] tests: add qmp/object-add-without-props test Marc-André Lureau
2018-08-30 12:51   ` Markus Armbruster
2018-08-30 15:23     ` Marc-André Lureau
2018-08-31  6:47       ` Markus Armbruster
2018-08-29 13:40 ` Marc-André Lureau [this message]
2018-08-30 13:05   ` [Qemu-devel] [PATCH v4 07/10] tests: add qmp/qom-set-without-value test Markus Armbruster
2018-08-30 13:10     ` Marc-André Lureau
2018-08-30 15:42     ` Marc-André Lureau
2018-08-31  6:30       ` Markus Armbruster
2018-08-29 13:40 ` [Qemu-devel] [PATCH v4 08/10] tests: add a qmp success-response test Marc-André Lureau
2018-08-30 13:14   ` Markus Armbruster
2018-08-29 13:40 ` [Qemu-devel] [PATCH v4 09/10] qga: process_event() simplification Marc-André Lureau
2018-08-30 13:57   ` Markus Armbruster
2018-10-02 19:04     ` Marc-André Lureau
2018-10-08 13:25       ` Markus Armbruster
2018-08-29 13:40 ` [Qemu-devel] [PATCH v4 10/10] qmp: common 'id' handling & make QGA conform to QMP spec Marc-André Lureau
2018-09-01 10:59   ` Markus Armbruster
2018-09-01 12:05     ` Marc-André Lureau
2018-09-03  5:19       ` Markus Armbruster
2018-10-02 19:06       ` Marc-André Lureau
2018-10-08 13:26         ` Markus Armbruster
2018-08-30 14:21 ` [Qemu-devel] [PATCH v4 00/10] monitor: various code simplification and fixes Markus Armbruster
2018-08-31  0:19   ` Michael Roth

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180829134043.31706-8-marcandre.lureau@redhat.com \
    --to=marcandre.lureau@redhat.com \
    --cc=armbru@redhat.com \
    --cc=peterx@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).