qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Zhang Chen <zhangckid@gmail.com>
To: qemu-devel@nongnu.org, Paolo Bonzini <pbonzini@redhat.com>,
	Juan Quintela <quintela@redhat.com>,
	"Dr . David Alan Gilbert" <dgilbert@redhat.com>,
	Jason Wang <jasowang@redhat.com>, Eric Blake <eblake@redhat.com>,
	Markus Armbruster <armbru@redhat.com>
Cc: Zhang Chen <zhangckid@gmail.com>,
	zhanghailiang <zhang.zhanghailiang@huawei.com>,
	Li Zhijian <lizhijian@cn.fujitsu.com>,
	Zhang Chen <chen.zhang@intel.com>
Subject: [Qemu-devel] [PATCH V12 11/19] qapi/migration.json: Rename COLO unknown mode to none mode.
Date: Mon,  3 Sep 2018 12:38:52 +0800	[thread overview]
Message-ID: <20180903043900.28592-12-zhangckid@gmail.com> (raw)
In-Reply-To: <20180903043900.28592-1-zhangckid@gmail.com>

From: Zhang Chen <chen.zhang@intel.com>

Suggested by Markus Armbruster rename COLO unknown mode to none mode.

Signed-off-by: Zhang Chen <zhangckid@gmail.com>
Signed-off-by: Zhang Chen <chen.zhang@intel.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Reviewed-by: Markus Armbruster <armbru@redhat.com>
---
 migration/colo-failover.c |  2 +-
 migration/colo.c          |  2 +-
 qapi/migration.json       | 10 +++++-----
 3 files changed, 7 insertions(+), 7 deletions(-)

diff --git a/migration/colo-failover.c b/migration/colo-failover.c
index 0ae0c41221..4854a96c92 100644
--- a/migration/colo-failover.c
+++ b/migration/colo-failover.c
@@ -77,7 +77,7 @@ FailoverStatus failover_get_state(void)
 
 void qmp_x_colo_lost_heartbeat(Error **errp)
 {
-    if (get_colo_mode() == COLO_MODE_UNKNOWN) {
+    if (get_colo_mode() == COLO_MODE_NONE) {
         error_setg(errp, QERR_FEATURE_DISABLED, "colo");
         return;
     }
diff --git a/migration/colo.c b/migration/colo.c
index 761fbb9f78..9107ac124a 100644
--- a/migration/colo.c
+++ b/migration/colo.c
@@ -160,7 +160,7 @@ COLOMode get_colo_mode(void)
     } else if (migration_incoming_in_colo_state()) {
         return COLO_MODE_SECONDARY;
     } else {
-        return COLO_MODE_UNKNOWN;
+        return COLO_MODE_NONE;
     }
 }
 
diff --git a/qapi/migration.json b/qapi/migration.json
index 9b3b1c0c4e..c0bc77fd8d 100644
--- a/qapi/migration.json
+++ b/qapi/migration.json
@@ -899,18 +899,18 @@
 ##
 # @COLOMode:
 #
-# The colo mode
+# The COLO current mode.
 #
-# @unknown: unknown mode
+# @none: COLO is disabled.
 #
-# @primary: master side
+# @primary: COLO node in primary side.
 #
-# @secondary: slave side
+# @secondary: COLO node in slave side.
 #
 # Since: 2.8
 ##
 { 'enum': 'COLOMode',
-  'data': [ 'unknown', 'primary', 'secondary'] }
+  'data': [ 'none', 'primary', 'secondary'] }
 
 ##
 # @FailoverStatus:
-- 
2.17.GIT

  parent reply	other threads:[~2018-09-03  4:41 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-03  4:38 [Qemu-devel] [PATCH V12 00/19] COLO: integrate colo frame with block replication and COLO proxy Zhang Chen
2018-09-03  4:38 ` [Qemu-devel] [PATCH V12 01/19] filter-rewriter: Add TCP state machine and fix memory leak in connection_track_table Zhang Chen
2018-09-12  7:36   ` Jason Wang
2018-09-13  3:12     ` Zhang Chen
2018-09-03  4:38 ` [Qemu-devel] [PATCH V12 02/19] colo-compare: implement the process of checkpoint Zhang Chen
2018-09-03  4:38 ` [Qemu-devel] [PATCH V12 03/19] colo-compare: use notifier to notify packets comparing result Zhang Chen
2018-09-03  4:38 ` [Qemu-devel] [PATCH V12 04/19] COLO: integrate colo compare with colo frame Zhang Chen
2018-09-03  4:38 ` [Qemu-devel] [PATCH V12 05/19] COLO: Add block replication into colo process Zhang Chen
2018-09-03  7:31   ` Zhang Chen
2018-10-24  7:21   ` Thomas Huth
2018-10-24  7:34     ` Zhang Chen
2018-09-03  4:38 ` [Qemu-devel] [PATCH V12 06/19] COLO: Remove colo_state migration struct Zhang Chen
2018-09-03  4:38 ` [Qemu-devel] [PATCH V12 07/19] COLO: Load dirty pages into SVM's RAM cache firstly Zhang Chen
2018-09-03  4:38 ` [Qemu-devel] [PATCH V12 08/19] ram/COLO: Record the dirty pages that SVM received Zhang Chen
2018-09-03  4:38 ` [Qemu-devel] [PATCH V12 09/19] COLO: Flush memory data from ram cache Zhang Chen
2018-09-03  4:38 ` [Qemu-devel] [PATCH V12 10/19] qmp event: Add COLO_EXIT event to notify users while exited COLO Zhang Chen
2018-09-03  4:38 ` Zhang Chen [this message]
2018-09-03  4:38 ` [Qemu-devel] [PATCH V12 12/19] qapi: Add new command to query colo status Zhang Chen
2018-09-03  4:38 ` [Qemu-devel] [PATCH V12 13/19] savevm: split the process of different stages for loadvm/savevm Zhang Chen
2018-09-03  4:38 ` [Qemu-devel] [PATCH V12 14/19] COLO: flush host dirty ram from cache Zhang Chen
2018-09-03  4:38 ` [Qemu-devel] [PATCH V12 15/19] filter: Add handle_event method for NetFilterClass Zhang Chen
2018-09-03  4:38 ` [Qemu-devel] [PATCH V12 16/19] filter-rewriter: handle checkpoint and failover event Zhang Chen
2018-09-03  4:38 ` [Qemu-devel] [PATCH V12 17/19] COLO: notify net filters about checkpoint/failover event Zhang Chen
2018-09-03  4:38 ` [Qemu-devel] [PATCH V12 18/19] COLO: quick failover process by kick COLO thread Zhang Chen
2018-09-03  4:39 ` [Qemu-devel] [PATCH V12 19/19] docs: Add COLO status diagram to COLO-FT.txt Zhang Chen
2018-09-12  7:43   ` Jason Wang
2018-09-10  8:16 ` [Qemu-devel] [PATCH V12 00/19] COLO: integrate colo frame with block replication and COLO proxy Zhang Chen
2018-09-12  7:50   ` Jason Wang
2018-09-13  3:10     ` Zhang Chen
2018-09-13  6:40       ` Zhang Chen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180903043900.28592-12-zhangckid@gmail.com \
    --to=zhangckid@gmail.com \
    --cc=armbru@redhat.com \
    --cc=chen.zhang@intel.com \
    --cc=dgilbert@redhat.com \
    --cc=eblake@redhat.com \
    --cc=jasowang@redhat.com \
    --cc=lizhijian@cn.fujitsu.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=quintela@redhat.com \
    --cc=zhang.zhanghailiang@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).