From: Fei Li <fli@suse.com>
To: qemu-devel@nongnu.org
Cc: fli@suse.com
Subject: [Qemu-devel] [PATCH 0/5] qemu_thread_create: propagate errors to callers to check
Date: Tue, 4 Sep 2018 19:08:17 +0800 [thread overview]
Message-ID: <20180904110822.12863-1-fli@suse.com> (raw)
Hi,
This idea comes from BiteSizedTasks, and this patch series implement
the error checking of qemu_thread_create: make qemu_thread_create
return a flag to indicate if it succeeded rather than failing with an
error; make all callers check it.
The first three patches apply to those call traces whose further
callers already have the *errp to pass, thus add a new Error paramater
in the call trace to propagate the error and let the final caller
check it. The fourth patch is dedicated for qemu_thread_create().
The fifth patch updates the direct callers of qemu_thread_create.
Please help to review. Thanks.
Fei Li (5):
Fix segmentation fault when qemu_signal_init fails
ui/vnc.c: polish vnc_init_func
qemu_init_vcpu: add a new Error paramater to propagate
qemu_thread_create: propagate the error to callers to check
Propagate qemu_thread_create's error to all callers to handle
cpus.c | 80 ++++++++++++++++++++++++++++++-----------
dump.c | 6 +++-
hw/misc/edu.c | 8 ++++-
hw/ppc/spapr_hcall.c | 9 ++++-
hw/rdma/rdma_backend.c | 3 +-
hw/usb/ccid-card-emulated.c | 13 +++++--
include/qemu/osdep.h | 2 +-
include/qemu/thread.h | 2 +-
include/qom/cpu.h | 2 +-
include/ui/console.h | 2 +-
io/task.c | 3 +-
iothread.c | 15 +++++---
migration/migration.c | 47 +++++++++++++++++-------
migration/postcopy-ram.c | 11 +++++-
migration/ram.c | 32 ++++++++++++++---
migration/savevm.c | 8 ++++-
target/alpha/cpu.c | 6 +++-
target/arm/cpu.c | 6 +++-
target/cris/cpu.c | 6 +++-
target/hppa/cpu.c | 6 +++-
target/i386/cpu.c | 6 +++-
target/lm32/cpu.c | 6 +++-
target/m68k/cpu.c | 6 +++-
target/microblaze/cpu.c | 6 +++-
target/mips/cpu.c | 6 +++-
target/moxie/cpu.c | 6 +++-
target/nios2/cpu.c | 6 +++-
target/openrisc/cpu.c | 6 +++-
target/ppc/translate_init.inc.c | 6 +++-
target/riscv/cpu.c | 6 +++-
target/s390x/cpu.c | 5 ++-
target/sh4/cpu.c | 6 +++-
target/sparc/cpu.c | 6 +++-
target/tilegx/cpu.c | 6 +++-
target/tricore/cpu.c | 6 +++-
target/unicore32/cpu.c | 6 +++-
target/xtensa/cpu.c | 6 +++-
tests/atomic_add-bench.c | 3 +-
tests/iothread.c | 2 +-
tests/qht-bench.c | 3 +-
tests/rcutorture.c | 3 +-
tests/test-aio.c | 2 +-
tests/test-rcu-list.c | 3 +-
ui/vnc-jobs.c | 13 +++++--
ui/vnc-jobs.h | 2 +-
ui/vnc.c | 15 ++++++--
util/compatfd.c | 25 +++++++++----
util/main-loop.c | 11 +++---
util/oslib-posix.c | 10 +++++-
util/qemu-thread-posix.c | 15 +++++---
util/qemu-thread-win32.c | 12 +++++--
util/rcu.c | 3 +-
util/thread-pool.c | 4 ++-
53 files changed, 386 insertions(+), 108 deletions(-)
--
2.13.7
next reply other threads:[~2018-09-04 11:09 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-04 11:08 Fei Li [this message]
2018-09-04 11:08 ` [Qemu-devel] [PATCH 1/5] Fix segmentation fault when qemu_signal_init fails Fei Li
2018-09-04 11:26 ` Daniel P. Berrangé
2018-09-05 4:17 ` Fei Li
2018-09-05 8:36 ` Daniel P. Berrangé
2018-09-05 11:20 ` Fei Li
2018-09-05 14:38 ` Fam Zheng
2018-09-06 6:31 ` Fei Li
2018-09-04 11:08 ` [Qemu-devel] [PATCH 2/5] ui/vnc.c: polish vnc_init_func Fei Li
2018-09-04 11:08 ` [Qemu-devel] [PATCH 3/5] qemu_init_vcpu: add a new Error paramater to propagate Fei Li
2018-09-04 11:22 ` Daniel P. Berrangé
2018-09-05 4:36 ` Fei Li
2018-09-05 17:15 ` Eric Blake
2018-09-06 6:52 ` Fei Li
2018-09-04 11:08 ` [Qemu-devel] [PATCH 4/5] qemu_thread_create: propagate the error to callers to check Fei Li
2018-09-04 11:18 ` Daniel P. Berrangé
2018-09-05 4:20 ` Fei Li
2018-09-04 11:08 ` [Qemu-devel] [PATCH 5/5] Propagate qemu_thread_create's error to all callers to handle Fei Li
2018-09-04 11:20 ` Daniel P. Berrangé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180904110822.12863-1-fli@suse.com \
--to=fli@suse.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).