From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38220) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fxMIe-0008Sy-6u for qemu-devel@nongnu.org; Tue, 04 Sep 2018 21:08:05 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fxMIa-0002vT-Qq for qemu-devel@nongnu.org; Tue, 04 Sep 2018 21:08:04 -0400 Received: from wout2-smtp.messagingengine.com ([64.147.123.25]:38141) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1fxMIa-0002tG-Af for qemu-devel@nongnu.org; Tue, 04 Sep 2018 21:08:00 -0400 Date: Tue, 4 Sep 2018 21:07:56 -0400 From: "Emilio G. Cota" Message-ID: <20180905010756.GA2373@flamenco> References: <20180810173941.5301-1-cota@braap.org> <20180831222249.GA28489@flamenco> <20180904233919.GA25010@flamenco> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Subject: Re: [Qemu-devel] [PATCH v2 0/3] target/riscv: use tcg_lookup_and_goto_ptr List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alistair Francis Cc: "qemu-devel@nongnu.org Developers" , Sagar Karandikar , Bastian Koppelmann , Palmer Dabbelt , Richard Henderson , Michael Clark , Alistair Francis On Tue, Sep 04, 2018 at 16:42:32 -0700, Alistair Francis wrote: > On Tue, Sep 4, 2018 at 4:39 PM, Emilio G. Cota wrote: > > On Tue, Sep 04, 2018 at 13:18:28 -0700, Alistair Francis wrote: > >> On Fri, Aug 31, 2018 at 3:22 PM, Emilio G. Cota wrote: > >> > On Fri, Aug 10, 2018 at 13:39:38 -0400, Emilio G. Cota wrote: > >> >> Changes wrt v1: changed patch 3 as suggested by Richard. Also > >> >> added his R-b's. > >> >> > >> >> You can fetch this series from: > >> >> https://github.com/cota/qemu/tree/riscv-lookup_ptr-v2 > >> > > >> > RISC-V maintainers: any plans of picking this up for 3.1? > >> > >> Thanks for CCing me. > >> > >> I think Michael must be really busy, I haven't seen any activity for > >> awhile. I'm going to send a PR with everything that has been reviewed > >> and applies cleanly. > > > > Thanks! > > > > Did patch 1 not apply cleanly? I see it's not part of the pullreq > > you just sent. > > > > I'd like the three patches to go in in the original order, since > > the perf numbers in patch 3's commit log are laid out assuming > > that is the case. > > The content of patch 1 was applied in this commit: > > commit 07ea28b41830f946de3841b0ac61a3413679feb9 > Author: Richard Henderson > Date: Wed May 30 18:06:23 2018 -0700 > > tcg: Pass tb and index to tcg_gen_exit_tb separately > > Do the cast to uintptr_t within the helper, so that the compiler > can type check the pointer argument. We can also do some more > sanity checking of the index argument. > > Reviewed-by: Laurent Vivier > Signed-off-by: Richard Henderson > > https://github.com/qemu/qemu/commit/07ea28b41830f946de3841b0ac61a3413679feb9 > > so unfortunately the patch no longer applies. If I rebase the 3 patches on top of the current master (19b599f7), the 3 patches apply cleanly, including patch 1: --- a/target/riscv/translate.c +++ b/target/riscv/translate.c @@ -135,7 +135,7 @@ static void gen_goto_tb(DisasContext *ctx, int n, targ if (ctx->base.singlestep_enabled) { gen_exception_debug(); } else { - tcg_gen_exit_tb(NULL, 0); + tcg_gen_lookup_and_goto_ptr(); } } } Did you apply the patches manually or pull from a branch? The latest branch I have on this is: https://github.com/cota/qemu/tree/riscv-lookup_ptr-v2 (although note that that branch doesn't have Richard's R-b tag for patch 3) Thanks, Emilio