From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
To: Collin Walling <walling@linux.ibm.com>
Cc: stzi@linux.ibm.com, qemu-devel@nongnu.org, armbru@redhat.com
Subject: Re: [Qemu-devel] [PATCH v2] monitor: print message when using 'help' with an unknown command
Date: Thu, 6 Sep 2018 20:28:42 +0100 [thread overview]
Message-ID: <20180906192841.GG2639@work-vm> (raw)
In-Reply-To: <c7781746-5bc5-be44-9596-b4504ea1d5a2@linux.ibm.com>
* Collin Walling (walling@linux.ibm.com) wrote:
> On 08/08/2018 03:00 PM, Dr. David Alan Gilbert wrote:
> > * Collin Walling (walling@linux.ibm.com) wrote:
> >> When typing 'help' followed by an unknown command, QEMU will
> >> not print anything to the command line to let the user know
> >> they typed a bad command. Let's fix this by printing a message
> >> to the monitor when this happens. For example:
> >>
> >> (qemu) help xyz
> >> unknown command: 'xyz'
> >>
> >> Reported-by: Stefan Zimmermann <stzi@linux.ibm.com>
> >> Signed-off-by: Collin Walling <walling@linux.ibm.com>
> >
> > Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
> >
>
> Thank you for the R-b.
>
> And pardon my impatience, but any chance this patch might get picked up, or
> does it require some more review first?
It will on my next HMP pull; it's just not many pulls are happening
at the moment; it should be in by the end of the month.
Dave
> [...]
>
>
> --
> Respectfully,
> - Collin Walling
>
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK
next prev parent reply other threads:[~2018-09-06 19:28 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-20 19:40 [Qemu-devel] [PATCH v2] monitor: print message when using 'help' with an unknown command Collin Walling
2018-08-08 19:00 ` Dr. David Alan Gilbert
2018-09-06 18:09 ` Collin Walling
2018-09-06 19:28 ` Dr. David Alan Gilbert [this message]
2018-09-06 20:35 ` Collin Walling
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180906192841.GG2639@work-vm \
--to=dgilbert@redhat.com \
--cc=armbru@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stzi@linux.ibm.com \
--cc=walling@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).