From: Fam Zheng <famz@redhat.com>
To: qemu-devel@nongnu.org
Cc: Peter Maydell <peter.maydell@linaro.org>
Subject: [Qemu-devel] [PULL 2/5] docker: Sort Fedora packages (i386-cross)
Date: Mon, 10 Sep 2018 11:57:16 +0800 [thread overview]
Message-ID: <20180910035719.18056-3-famz@redhat.com> (raw)
In-Reply-To: <20180910035719.18056-1-famz@redhat.com>
From: Philippe Mathieu-Daudé <f4bug@amsat.org>
As recommended in https://docs.docker.com/develop/develop-images/dockerfile_best-practices/#sort-multi-line-arguments
"This helps to avoid duplication of packages and make the
list much easier to update. This also makes PRs a lot easier
to read and review."
Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Message-Id: <20180818015344.797-3-f4bug@amsat.org>
Signed-off-by: Fam Zheng <famz@redhat.com>
---
tests/docker/dockerfiles/fedora-i386-cross.docker | 9 ++++-----
1 file changed, 4 insertions(+), 5 deletions(-)
diff --git a/tests/docker/dockerfiles/fedora-i386-cross.docker b/tests/docker/dockerfiles/fedora-i386-cross.docker
index 8fbef2fa53..a4fd895b07 100644
--- a/tests/docker/dockerfiles/fedora-i386-cross.docker
+++ b/tests/docker/dockerfiles/fedora-i386-cross.docker
@@ -1,14 +1,13 @@
FROM fedora:latest
ENV PACKAGES \
gcc \
- glibc-static.i686 \
+ glib2-devel.i686 \
glibc-devel.i686 \
- glib2-devel.i686 \
- zlib-devel.i686 \
- glib2-devel.i686 \
+ glibc-static.i686 \
+ gnutls-devel.i686 \
nettle-devel.i686 \
pixman-devel.i686 \
- gnutls-devel.i686
+ zlib-devel.i686
RUN dnf install -y $PACKAGES
RUN rpm -q $PACKAGES | sort > /packages.txt
--
2.17.1
next prev parent reply other threads:[~2018-09-10 3:57 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-10 3:57 [Qemu-devel] [PULL 0/5] Docker patches Fam Zheng
2018-09-10 3:57 ` [Qemu-devel] [PULL 1/5] docker: Sort Fedora packages Fam Zheng
2018-09-10 3:57 ` Fam Zheng [this message]
2018-09-10 3:57 ` [Qemu-devel] [PULL 3/5] docker: Sort Ubuntu packages Fam Zheng
2018-09-10 3:57 ` [Qemu-devel] [PULL 4/5] docker: Sort CentOS packages Fam Zheng
2018-09-10 3:57 ` [Qemu-devel] [PULL 5/5] docker: Clean dangling tarball files Fam Zheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180910035719.18056-3-famz@redhat.com \
--to=famz@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).