From: Kevin Wolf <kwolf@redhat.com>
To: Alberto Garcia <berto@igalia.com>
Cc: qemu-devel@nongnu.org, qemu-block@nongnu.org,
Max Reitz <mreitz@redhat.com>,
qemu-stable@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] block: Fix use after free error in bdrv_open_inherit()
Date: Mon, 10 Sep 2018 10:34:20 +0200 [thread overview]
Message-ID: <20180910083420.GC4901@dhcp-200-186.str.redhat.com> (raw)
In-Reply-To: <20180906142541.8238-1-berto@igalia.com>
Am 06.09.2018 um 16:25 hat Alberto Garcia geschrieben:
> When a block device is opened with BDRV_O_SNAPSHOT and the
> bdrv_append_temp_snapshot() call fails then the error code path tries
> to unref the already destroyed 'options' QDict.
>
> This can be reproduced easily by setting TMPDIR to a location where
> the QEMU process can't write:
>
> $ TMPDIR=/nonexistent $QEMU -drive driver=null-co,snapshot=on
>
> Signed-off-by: Alberto Garcia <berto@igalia.com>
Thanks, applied to the block branch.
But can we add the reproducer to some iotests case?
Kevin
next prev parent reply other threads:[~2018-09-10 8:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-06 14:25 [Qemu-devel] [PATCH] block: Fix use after free error in bdrv_open_inherit() Alberto Garcia
2018-09-10 8:34 ` Kevin Wolf [this message]
2018-09-10 9:34 ` Alberto Garcia
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180910083420.GC4901@dhcp-200-186.str.redhat.com \
--to=kwolf@redhat.com \
--cc=berto@igalia.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-stable@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).