From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56360) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1g02lr-0004dr-QV for qemu-devel@nongnu.org; Wed, 12 Sep 2018 06:53:23 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1g02Y7-00054g-Gx for qemu-devel@nongnu.org; Wed, 12 Sep 2018 06:39:08 -0400 Date: Wed, 12 Sep 2018 12:38:56 +0200 From: Kevin Wolf Message-ID: <20180912103856.GC5846@localhost.localdomain> References: <570e8585c94d6f1bd7406ce5d35f68a82b6ea28c.1536642773.git.jcody@redhat.com> <10f55c86-32dc-957a-c050-32a58baaddbd@redhat.com> <20180911183700.GQ22117@localhost.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180911183700.GQ22117@localhost.localdomain> Subject: Re: [Qemu-devel] [PATCH 2/2] block/rbd: Attempt to parse legacy filenames List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jeff Cody Cc: John Snow , qemu-devel@nongnu.org, qemu-stable@nongnu.org, qemu-block@nongnu.org, armbru@redhat.com Am 11.09.2018 um 20:37 hat Jeff Cody geschrieben: > On Tue, Sep 11, 2018 at 02:22:31PM -0400, John Snow wrote: > > Once we load the image, will the header get rewritten into a compliant > > format? > > Hmm - I think in some code paths, but not all. I don't think the answer is > 'yes' universally, alas. Can't we explicitly call BdrvChildRole.update_filename() for all parents when we open a legacy filename? We'd just need to add the callback to child_file, which would propagate it to the parents of the format layer, and then just opening the image with a legacy backing file link once would fix the problem for this image. Kevin