From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46871) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1g0Vev-0006sR-M5 for qemu-devel@nongnu.org; Thu, 13 Sep 2018 13:44:09 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1g0Vel-0003Ni-5b for qemu-devel@nongnu.org; Thu, 13 Sep 2018 13:43:59 -0400 Date: Thu, 13 Sep 2018 19:39:26 +0200 From: Kevin Wolf Message-ID: <20180913173926.GE5172@localhost.localdomain> References: <20180913125217.23173-1-kwolf@redhat.com> <20180913125217.23173-7-kwolf@redhat.com> <387dce30-0a62-ad0a-e955-56ca714323b4@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <387dce30-0a62-ad0a-e955-56ca714323b4@redhat.com> Subject: Re: [Qemu-devel] [PATCH v2 06/17] job: Use AIO_WAIT_WHILE() in job_finish_sync() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: qemu-block@nongnu.org, mreitz@redhat.com, famz@redhat.com, slp@redhat.com, jsnow@redhat.com, qemu-devel@nongnu.org Am 13.09.2018 um 17:15 hat Paolo Bonzini geschrieben: > On 13/09/2018 14:52, Kevin Wolf wrote: > > Also, job_drain() without aio_poll() isn't necessarily enough to make > > progress on a job, it could depend on bottom halves to be executed. > > This is not changed by the patch though; AIO_WAIT_WHILE does not do the > bottom halves part anymore, bdrv_drain_poll_top_level does it instead. > > What is it that needs bottom halves to be executed? Could it delay > switching the job state until after that? AIO_WAIT_WHILE() does still execute bottom halves if the condition is true, which is all that is needed to make progress. It only doesn't execute them unconditionally any more. Kevin