From: Gerd Hoffmann <kraxel@redhat.com>
To: "Marc-André Lureau" <marcandre.lureau@redhat.com>
Cc: qemu-devel@nongnu.org, libvir-list@redhat.com,
"Daniel P . Berrangé" <berrange@redhat.com>,
"Changpeng Liu" <changpeng.liu@intel.com>,
"Dr . David Alan Gilbert" <dgilbert@redhat.com>,
"Felipe Franciosi" <felipe@nutanix.com>,
Gonglei <arei.gonglei@huawei.com>,
"Maxime Coquelin" <maxime.coquelin@redhat.com>,
"Michael S . Tsirkin" <mst@redhat.com>,
"Victor Kaplansky" <victork@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] vhost-user: define conventions for vhost-user backends
Date: Fri, 14 Sep 2018 12:55:30 +0200 [thread overview]
Message-ID: <20180914105530.nxpfaqgegyktdpcp@sirius.home.kraxel.org> (raw)
In-Reply-To: <20180913112205.3252-1-marcandre.lureau@redhat.com>
Hi,
> +* --pidfile=PATH
> +
> +Write the process id (PID) to the given file PATH. This is mostly
> +useful if the backend daemonize/fork itself.
Is there any reason to daemonize itself?
If not: shoud we disallow it and drop the --pidfile switch?
If yes: should we add a --daemonize switch then to control whenever the
process daemonizes itself?
Otherwise the conventions look good to me.
cheers,
Gerd
next prev parent reply other threads:[~2018-09-14 10:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-13 11:22 [Qemu-devel] [PATCH] vhost-user: define conventions for vhost-user backends Marc-André Lureau
2018-09-14 10:55 ` Gerd Hoffmann [this message]
2018-09-14 12:43 ` Marc-André Lureau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180914105530.nxpfaqgegyktdpcp@sirius.home.kraxel.org \
--to=kraxel@redhat.com \
--cc=arei.gonglei@huawei.com \
--cc=berrange@redhat.com \
--cc=changpeng.liu@intel.com \
--cc=dgilbert@redhat.com \
--cc=felipe@nutanix.com \
--cc=libvir-list@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=maxime.coquelin@redhat.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=victork@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).