From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] usb: assign unique serial numbers to hid devices
Date: Fri, 14 Sep 2018 11:57:23 +0100 [thread overview]
Message-ID: <20180914105722.GA3081@work-vm> (raw)
In-Reply-To: <20180914104802.hhbktwbxh7swkeh7@sirius.home.kraxel.org>
* Gerd Hoffmann (kraxel@redhat.com) wrote:
> > > + [STR_SERIAL_MOUSE] = "89126",
> > > + [STR_SERIAL_TABLET] = "28754",
> > > + [STR_SERIAL_KEYBOARD] = "68284",
> >
> > Is there any significance to the magical numbers?
>
> No, other than that the three device types should have different ones.
OK, I had vague memories a while ago of us asking about encoding things
in serial numbers and the previous 42 not actually being magical.
> > Will this change trigger a serial number change across migrate
> > or will the current serial be carried across?
>
> No, it is not migrated over.
> So I guess we should better add a compat property ...
Thanks,
Dave
> cheers,
> Gerd
>
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK
prev parent reply other threads:[~2018-09-14 10:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-14 9:56 [Qemu-devel] [PATCH] usb: assign unique serial numbers to hid devices Gerd Hoffmann
2018-09-14 10:20 ` Dr. David Alan Gilbert
2018-09-14 10:48 ` Gerd Hoffmann
2018-09-14 10:57 ` Dr. David Alan Gilbert [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180914105722.GA3081@work-vm \
--to=dgilbert@redhat.com \
--cc=kraxel@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).