[Qemu-devel] [PULL 0/1] seccomp branch queue

[Qemu-devel] [PULL 0/1] seccomp branch queue

[Eduardo Otubo]

The following changes since commit 19b599f7664b2ebfd0f405fb79c14dd241557452:

  Merge remote-tracking branch 'remotes/armbru/tags/pull-error-2018-08-27-v2' into staging (2018-08-27 16:44:20 +0100)

are available in the Git repository at:

  https://github.com/otubo/qemu.git tags/pull-seccomp-20180914

for you to fetch changes up to d3228ed3829981047138bbaff332026f9d64f337:

  seccomp: check TSYNC host capability (2018-09-14 15:01:55 +0200)

----------------------------------------------------------------
pull-seccomp-20180914

----------------------------------------------------------------
Marc-André Lureau (1):
      seccomp: check TSYNC host capability

 qemu-seccomp.c | 19 ++++++++++++++++++-
 vl.c           |  4 ++--
 2 files changed, 20 insertions(+), 3 deletions(-)

-- 
2.17.1

[Qemu-devel] [PULL 1/1] seccomp: check TSYNC host capability

[Eduardo Otubo]

From: Marc-André Lureau <marcandre.lureau@redhat.com>

Remove -sandbox option if the host is not capable of TSYNC, since the
sandbox will fail at setup time otherwise. This will help libvirt, for
ex, to figure out if -sandbox will work.

Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Acked-by: Eduardo Otubo <otubo@redhat.com>
---
 qemu-seccomp.c | 19 ++++++++++++++++++-
 vl.c           |  4 ++--
 2 files changed, 20 insertions(+), 3 deletions(-)

diff --git a/qemu-seccomp.c b/qemu-seccomp.c
index 4729eb107f..1baa5c69ed 100644
--- a/qemu-seccomp.c
+++ b/qemu-seccomp.c
@@ -282,7 +282,24 @@ static QemuOptsList qemu_sandbox_opts = {
 
 static void seccomp_register(void)
 {
-    qemu_add_opts(&qemu_sandbox_opts);
+    bool add = false;
+
+    /* FIXME: use seccomp_api_get() >= 2 check when released */
+
+#if defined(SECCOMP_FILTER_FLAG_TSYNC)
+    int check;
+
+    /* check host TSYNC capability, it returns errno == ENOSYS if unavailable */
+    check = qemu_seccomp(SECCOMP_SET_MODE_FILTER,
+                         SECCOMP_FILTER_FLAG_TSYNC, NULL);
+    if (check < 0 && errno == EFAULT) {
+        add = true;
+    }
+#endif
+
+    if (add) {
+        qemu_add_opts(&qemu_sandbox_opts);
+    }
 }
 opts_init(seccomp_register);
 #endif
diff --git a/vl.c b/vl.c
index 5ba06adf78..380ae7ba2b 100644
--- a/vl.c
+++ b/vl.c
@@ -4007,8 +4007,8 @@ int main(int argc, char **argv, char **envp)
     }
 
 #ifdef CONFIG_SECCOMP
-    if (qemu_opts_foreach(qemu_find_opts("sandbox"),
-                          parse_sandbox, NULL, NULL)) {
+    olist = qemu_find_opts_err("sandbox", NULL);
+    if (olist && qemu_opts_foreach(olist, parse_sandbox, NULL, NULL)) {
         exit(1);
     }
 #endif
-- 
2.17.1

[Qemu-devel] [PULL 0/1] seccomp branch queue

[Eduardo Otubo]

The following changes since commit 532cc6da74ec25b5ba6893b5757c977d54582949:

  Update version for v4.0.0-rc3 release (2019-04-10 15:38:59 +0100)

are available in the Git repository at:

  https://github.com/otubo/qemu.git tags/pull-seccomp-20190412

for you to fetch changes up to ee352b53b3e49ba9621149f9de7279a5cadd606c:

  configure: Relax check for libseccomp (2019-04-12 13:30:40 +0200)

----------------------------------------------------------------
pull-seccomp-20190412

----------------------------------------------------------------
Helge Deller (1):
      configure: Relax check for libseccomp

 configure | 28 ++++------------------------
 1 file changed, 4 insertions(+), 24 deletions(-)

-- 
2.17.2

[Qemu-devel] [PULL 0/1] seccomp branch queue

[Eduardo Otubo]

The following changes since commit 532cc6da74ec25b5ba6893b5757c977d54582949:

  Update version for v4.0.0-rc3 release (2019-04-10 15:38:59 +0100)

are available in the Git repository at:

  https://github.com/otubo/qemu.git tags/pull-seccomp-20190412

for you to fetch changes up to ee352b53b3e49ba9621149f9de7279a5cadd606c:

  configure: Relax check for libseccomp (2019-04-12 13:30:40 +0200)

----------------------------------------------------------------
pull-seccomp-20190412

----------------------------------------------------------------
Helge Deller (1):
      configure: Relax check for libseccomp

 configure | 28 ++++------------------------
 1 file changed, 4 insertions(+), 24 deletions(-)

-- 
2.17.2

Re: [Qemu-devel] [PULL 0/1] seccomp branch queue

[Peter Maydell]

On Fri, 12 Apr 2019 at 12:37, Eduardo Otubo <otubo@redhat.com> wrote:
>
> The following changes since commit 532cc6da74ec25b5ba6893b5757c977d54582949:
>
>   Update version for v4.0.0-rc3 release (2019-04-10 15:38:59 +0100)
>
> are available in the Git repository at:
>
>   https://github.com/otubo/qemu.git tags/pull-seccomp-20190412
>
> for you to fetch changes up to ee352b53b3e49ba9621149f9de7279a5cadd606c:
>
>   configure: Relax check for libseccomp (2019-04-12 13:30:40 +0200)
>
> ----------------------------------------------------------------
> pull-seccomp-20190412
>
> ----------------------------------------------------------------
> Helge Deller (1):
>       configure: Relax check for libseccomp

Is this really release critical? If you're sending pull
requests for rc3/rc4 it is extremely helpful if you can
give the justification for why they need to go into this
release. (As it happens we're going to need an rc4, but
I want to keep the set of changes in it to a minimum.)

thanks
-- PMM

Re: [Qemu-devel] [PULL 0/1] seccomp branch queue

[Peter Maydell]

On Fri, 12 Apr 2019 at 12:37, Eduardo Otubo <otubo@redhat.com> wrote:
>
> The following changes since commit 532cc6da74ec25b5ba6893b5757c977d54582949:
>
>   Update version for v4.0.0-rc3 release (2019-04-10 15:38:59 +0100)
>
> are available in the Git repository at:
>
>   https://github.com/otubo/qemu.git tags/pull-seccomp-20190412
>
> for you to fetch changes up to ee352b53b3e49ba9621149f9de7279a5cadd606c:
>
>   configure: Relax check for libseccomp (2019-04-12 13:30:40 +0200)
>
> ----------------------------------------------------------------
> pull-seccomp-20190412
>
> ----------------------------------------------------------------
> Helge Deller (1):
>       configure: Relax check for libseccomp

Is this really release critical? If you're sending pull
requests for rc3/rc4 it is extremely helpful if you can
give the justification for why they need to go into this
release. (As it happens we're going to need an rc4, but
I want to keep the set of changes in it to a minimum.)

thanks
-- PMM

Re: [Qemu-devel] [PULL 0/1] seccomp branch queue

[Eduardo Otubo]

[-- Attachment #1: Type: text/plain, Size: 1403 bytes --]

On 12/04/2019 - 12:52:48, Peter Maydell wrote:
> On Fri, 12 Apr 2019 at 12:37, Eduardo Otubo <otubo@redhat.com> wrote:
> >
> > The following changes since commit 532cc6da74ec25b5ba6893b5757c977d54582949:
> >
> >   Update version for v4.0.0-rc3 release (2019-04-10 15:38:59 +0100)
> >
> > are available in the Git repository at:
> >
> >   https://github.com/otubo/qemu.git tags/pull-seccomp-20190412
> >
> > for you to fetch changes up to ee352b53b3e49ba9621149f9de7279a5cadd606c:
> >
> >   configure: Relax check for libseccomp (2019-04-12 13:30:40 +0200)
> >
> > ----------------------------------------------------------------
> > pull-seccomp-20190412
> >
> > ----------------------------------------------------------------
> > Helge Deller (1):
> >       configure: Relax check for libseccomp
> 
> Is this really release critical? If you're sending pull
> requests for rc3/rc4 it is extremely helpful if you can
> give the justification for why they need to go into this
> release. (As it happens we're going to need an rc4, but
> I want to keep the set of changes in it to a minimum.)
> 

This is not critical. I'll send again after the current release.

-- 
Eduardo Otubo

Red Hat GmbH,http://www.de.redhat.com/, Sitz: Grasbrunn,
Handelsregister: Amtsgericht München, HRB 153243,
Geschäftsführer: Charles Cachera, Michael O'Neill, Tom Savage, Eric Shander

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 455 bytes --]

Re: [Qemu-devel] [PULL 0/1] seccomp branch queue

[Eduardo Otubo]

[-- Attachment #1: Type: text/plain, Size: 1403 bytes --]

On 12/04/2019 - 12:52:48, Peter Maydell wrote:
> On Fri, 12 Apr 2019 at 12:37, Eduardo Otubo <otubo@redhat.com> wrote:
> >
> > The following changes since commit 532cc6da74ec25b5ba6893b5757c977d54582949:
> >
> >   Update version for v4.0.0-rc3 release (2019-04-10 15:38:59 +0100)
> >
> > are available in the Git repository at:
> >
> >   https://github.com/otubo/qemu.git tags/pull-seccomp-20190412
> >
> > for you to fetch changes up to ee352b53b3e49ba9621149f9de7279a5cadd606c:
> >
> >   configure: Relax check for libseccomp (2019-04-12 13:30:40 +0200)
> >
> > ----------------------------------------------------------------
> > pull-seccomp-20190412
> >
> > ----------------------------------------------------------------
> > Helge Deller (1):
> >       configure: Relax check for libseccomp
> 
> Is this really release critical? If you're sending pull
> requests for rc3/rc4 it is extremely helpful if you can
> give the justification for why they need to go into this
> release. (As it happens we're going to need an rc4, but
> I want to keep the set of changes in it to a minimum.)
> 

This is not critical. I'll send again after the current release.

-- 
Eduardo Otubo

Red Hat GmbH,http://www.de.redhat.com/, Sitz: Grasbrunn,
Handelsregister: Amtsgericht München, HRB 153243,
Geschäftsführer: Charles Cachera, Michael O'Neill, Tom Savage, Eric Shander

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 455 bytes --]

[Qemu-devel] [PULL 0/1] seccomp branch queue

[Eduardo Otubo]

The following changes since commit c447afd5783b9237fa51b7a85777007d8d568bfc:

  Update version for v3.0.0-rc0 release (2018-07-10 18:19:50 +0100)

are available in the Git repository at:

  https://github.com/otubo/qemu.git tags/pull-seccomp-20180712

for you to fetch changes up to 056de1e894155fbb99e7b43c1c4382d4920cf437:

  seccomp: allow sched_setscheduler() with SCHED_IDLE policy (2018-07-12 14:52:39 +0200)

----------------------------------------------------------------
pull-seccomp-20180712

----------------------------------------------------------------
Marc-André Lureau (1):
      seccomp: allow sched_setscheduler() with SCHED_IDLE policy

 qemu-seccomp.c | 12 ++++++++++--
 1 file changed, 10 insertions(+), 2 deletions(-)

-- 
2.17.1

Re: [Qemu-devel] [PULL 0/1] seccomp branch queue

[Peter Maydell]

On 12 July 2018 at 14:25, Eduardo Otubo <otubo@redhat.com> wrote:
> The following changes since commit c447afd5783b9237fa51b7a85777007d8d568bfc:
>
>   Update version for v3.0.0-rc0 release (2018-07-10 18:19:50 +0100)
>
> are available in the Git repository at:
>
>   https://github.com/otubo/qemu.git tags/pull-seccomp-20180712
>
> for you to fetch changes up to 056de1e894155fbb99e7b43c1c4382d4920cf437:
>
>   seccomp: allow sched_setscheduler() with SCHED_IDLE policy (2018-07-12 14:52:39 +0200)
>
> ----------------------------------------------------------------
> pull-seccomp-20180712
>
> ----------------------------------------------------------------
> Marc-André Lureau (1):
>       seccomp: allow sched_setscheduler() with SCHED_IDLE policy
>
>  qemu-seccomp.c | 12 ++++++++++--
>  1 file changed, 10 insertions(+), 2 deletions(-)


Applied, thanks.

-- PMM