qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Luc Michel <luc.michel@greensocs.com>
To: qemu-devel@nongnu.org
Cc: "Luc Michel" <luc.michel@greensocs.com>,
	qemu-arm@nongnu.org, "Peter Maydell" <peter.maydell@linaro.org>,
	saipava@xilinx.com, edgari@xilinx.com, alistair@alistair23.me,
	"Philippe Mathieu-Daudé" <f4bug@amsat.org>,
	mark.burton@greensocs.com
Subject: [Qemu-devel] [PATCH v2 13/15] gdbstub: gdb_set_stop_cpu: ignore request when process is not attached
Date: Mon,  1 Oct 2018 13:57:02 +0200	[thread overview]
Message-ID: <20181001115704.701-14-luc.michel@greensocs.com> (raw)
In-Reply-To: <20181001115704.701-1-luc.michel@greensocs.com>

When gdb_set_stop_cpu() is called with a CPU associated to a process
currently not attached by the GDB client, return without modifying the
stop CPU. Otherwise, GDB get confused if it receives packets with a
thread-id it does not know about.

Signed-off-by: Luc Michel <luc.michel@greensocs.com>
---
 gdbstub.c | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/gdbstub.c b/gdbstub.c
index c27a3edf1d..51cc11981e 100644
--- a/gdbstub.c
+++ b/gdbstub.c
@@ -1763,10 +1763,19 @@ static int gdb_handle_packet(GDBState *s, const char *line_buf)
     return RS_IDLE;
 }
 
 void gdb_set_stop_cpu(CPUState *cpu)
 {
+    GDBProcess *p = gdb_get_cpu_process(gdbserver_state, cpu);
+
+    if (!p->attached) {
+        /* Having a stop CPU corresponding to a process that is not attached
+         * confuses GDB. So we ignore the request.
+         */
+        return;
+    }
+
     gdbserver_state->c_cpu = cpu;
     gdbserver_state->g_cpu = cpu;
 }
 
 #ifndef CONFIG_USER_ONLY
-- 
2.19.0

  parent reply	other threads:[~2018-10-01 11:57 UTC|newest]

Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-01 11:56 [Qemu-devel] [PATCH v2 00/15] gdbstub: support for the multiprocess extension Luc Michel
2018-10-01 11:56 ` [Qemu-devel] [PATCH v2 01/15] gdbstub: introduce GDB processes Luc Michel
2018-10-01 16:15   ` Philippe Mathieu-Daudé
2018-10-01 11:56 ` [Qemu-devel] [PATCH v2 02/15] gdbstub: add multiprocess support to '?' packets Luc Michel
2018-10-01 15:20   ` Philippe Mathieu-Daudé
2018-10-01 11:56 ` [Qemu-devel] [PATCH v2 03/15] gdbstub: add multiprocess support to 'H' and 'T' packets Luc Michel
2018-10-01 17:07   ` Philippe Mathieu-Daudé
2018-10-01 11:56 ` [Qemu-devel] [PATCH v2 04/15] gdbstub: add multiprocess support to vCont packets Luc Michel
2018-10-01 17:00   ` Philippe Mathieu-Daudé
2018-10-01 11:56 ` [Qemu-devel] [PATCH v2 05/15] gdbstub: add multiprocess support to 'sC' packets Luc Michel
2018-10-04 17:33   ` Alistair Francis
2018-10-01 11:56 ` [Qemu-devel] [PATCH v2 06/15] gdbstub: add multiprocess support to (f|s)ThreadInfo and ThreadExtraInfo Luc Michel
2018-10-01 17:15   ` Philippe Mathieu-Daudé
2018-10-01 11:56 ` [Qemu-devel] [PATCH v2 07/15] gdbstub: add multiprocess support to Xfer:features:read: Luc Michel
2018-10-01 16:28   ` Philippe Mathieu-Daudé
2018-10-01 11:56 ` [Qemu-devel] [PATCH v2 08/15] gdbstub: add multiprocess support to gdb_vm_state_change() Luc Michel
2018-10-01 16:30   ` Philippe Mathieu-Daudé
2018-10-01 11:56 ` [Qemu-devel] [PATCH v2 09/15] gdbstub: add multiprocess support to 'D' packets Luc Michel
2018-10-01 11:56 ` [Qemu-devel] [PATCH v2 10/15] gdbstub: add support for extended mode packet Luc Michel
2018-10-01 16:39   ` Philippe Mathieu-Daudé
2018-10-02  9:26     ` Luc Michel
2018-10-01 11:57 ` [Qemu-devel] [PATCH v2 11/15] gdbstub: add support for vAttach packets Luc Michel
2018-10-01 16:45   ` Philippe Mathieu-Daudé
2018-10-01 11:57 ` [Qemu-devel] [PATCH v2 12/15] gdbstub: processes initialization on new peer connection Luc Michel
2018-10-04 17:42   ` Alistair Francis
2018-10-01 11:57 ` Luc Michel [this message]
2018-10-01 11:57 ` [Qemu-devel] [PATCH v2 14/15] gdbstub: add multiprocess extension support Luc Michel
2018-10-01 16:35   ` Philippe Mathieu-Daudé
2018-10-01 11:57 ` [Qemu-devel] [PATCH v2 15/15] arm/xlnx-zynqmp: put APUs and RPUs in separate GDB groups Luc Michel
2018-10-02 11:33   ` Philippe Mathieu-Daudé
2018-10-02 11:58     ` Peter Maydell
2018-10-03 11:44       ` Luc Michel
2018-10-04 16:07         ` Philippe Mathieu-Daudé
2018-10-04 19:52           ` Eduardo Habkost
2018-10-04 20:01             ` Peter Maydell
2018-10-04 21:53               ` Eduardo Habkost
2018-10-05 13:50                 ` Philippe Mathieu-Daudé
2018-10-05 18:49                   ` Eduardo Habkost
2018-10-17 17:02                     ` Luc Michel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181001115704.701-14-luc.michel@greensocs.com \
    --to=luc.michel@greensocs.com \
    --cc=alistair@alistair23.me \
    --cc=edgari@xilinx.com \
    --cc=f4bug@amsat.org \
    --cc=mark.burton@greensocs.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-arm@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=saipava@xilinx.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).