qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Kevin Wolf <kwolf@redhat.com>
To: Eric Blake <eblake@redhat.com>
Cc: Leonid Bloch <lbloch@janustech.com>,
	qemu-devel@nongnu.org, qemu-block@nongnu.org,
	Max Reitz <mreitz@redhat.com>, Alberto Garcia <berto@igalia.com>
Subject: Re: [Qemu-devel] [PATCH] qcow2: Fix cache-clean-interval documentation
Date: Mon, 1 Oct 2018 18:59:45 +0200	[thread overview]
Message-ID: <20181001165945.GD4445@localhost.localdomain> (raw)
In-Reply-To: <dd15dbb9-6aaa-ab5a-9105-8cf49e76cc27@redhat.com>

Am 01.10.2018 um 16:35 hat Eric Blake geschrieben:
> On 9/29/18 4:54 AM, Leonid Bloch wrote:
> > Fixing cache-clean-interval documentation following the recent change to
> > a default of 600 seconds on supported plarforms (only Linux currently).
> > 
> > Signed-off-by: Leonid Bloch <lbloch@janustech.com>
> > ---
> >   docs/qcow2-cache.txt | 19 +++++++++----------
> >   qapi/block-core.json |  3 ++-
> >   qemu-options.hx      |  3 ++-
> >   3 files changed, 13 insertions(+), 12 deletions(-)
> > 
> > diff --git a/docs/qcow2-cache.txt b/docs/qcow2-cache.txt
> > index 59358b816f..1778312e09 100644
> > --- a/docs/qcow2-cache.txt
> > +++ b/docs/qcow2-cache.txt
> > @@ -202,18 +202,17 @@ Reducing the memory usage
> >   It is possible to clean unused cache entries in order to reduce the
> >   memory usage during periods of low I/O activity.
> > -The parameter "cache-clean-interval" defines an interval (in seconds).
> > -All cache entries that haven't been accessed during that interval are
> > -removed from memory.
> > +The parameter "cache-clean-interval" defines an interval (in seconds),
> > +affer which all the cache entries that haven't been accessed during it
> 
> s/affer/after/
> 
> Maybe s/during it/during the interval/

Thanks, made these fixes and applied it to the block branch.

Kevin

  reply	other threads:[~2018-10-01 16:59 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20180929095454.32066-1-lbloch@janustech.com>
2018-10-01 14:35 ` [Qemu-devel] [PATCH] qcow2: Fix cache-clean-interval documentation Eric Blake
2018-10-01 16:59   ` Kevin Wolf [this message]
2018-10-02  9:50     ` Leonid Bloch

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181001165945.GD4445@localhost.localdomain \
    --to=kwolf@redhat.com \
    --cc=berto@igalia.com \
    --cc=eblake@redhat.com \
    --cc=lbloch@janustech.com \
    --cc=mreitz@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).